Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 8 Jun 2021 19:49:42 +0200
From:   Michal Hocko <mhocko@suse.com>
To:     Yang Shi <shy828301@gmail.com>
Cc:     Zi Yan <ziy@nvidia.com>, nao.horiguchi@gmail.com,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Hugh Dickins <hughd@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: mempolicy: don't have to split pmd for huge zero page
Message-ID: <YL+ttjqJ9lEMndiA@dhcp22.suse.cz>
References: <20210604203513.240709-1-shy828301@gmail.com>
 <YL265A86DQe5Rgon@dhcp22.suse.cz>
 <CAHbLzkowcskM=p==-q48Ca12D=h9SgqUuUB4NknRNR=64TyXCw@mail.gmail.com>
 <YL5rvdzh9dou+uAz@dhcp22.suse.cz>
 <CAHbLzkooYAi=Hb0=oJ+2b6G=h5Sx4jnyo5L0nPYjDcBqBHnfug@mail.gmail.com>
 <YL8RFneAmSSi2Z0I@dhcp22.suse.cz>
 <CAHbLzkquqKOL7pH8yBdfpafeHJCUZvccNKjQBucsP7C4k83f7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHbLzkquqKOL7pH8yBdfpafeHJCUZvccNKjQBucsP7C4k83f7g@mail.gmail.com>
Precedence: bulk

On Tue 08-06-21 10:15:36, Yang Shi wrote:
[...]
> I did some archeology, the findings are:
> 
> The zero page has PageReserved flag set, it was skipped by the
> explicit PageReserved check in mempolicy.c since commit f4598c8b3678
> ("[PATCH] migration: make sure there is no attempt to migrate reserved
> pages."). The zero page was not used anymore by do_anonymous_page()
> since 2.6.24 by commit 557ed1fa2620 ("remove ZERO_PAGE"), then
> reinstated by commit a13ea5b759645 ("mm: reinstate ZERO_PAGE") and
> this commit added zero page check in vm_normal_page(), so mempolicy
> doesn't depend on PageReserved check to skip zero page anymore since
> then.
> 
> So the zero page is skipped by mempolicy.c since 2.6.16.

Thanks a lot! This is really useful. Can you just add it to the
changelog so others do not have to go through the painful archeology.

With that, feel free to add
Acked-by: Michal Hocko <mhocko@suse.com>

Thanls!
-- 
Michal Hocko
SUSE Labs