Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 8 Jun 2021 19:51:02 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     qiang.zhang@windriver.com
Cc:     ryabinin.a.a@gmail.com, glider@google.com, dvyukov@google.com,
        matthias.bgg@gmail.com, andreyknvl@google.com,
        akpm@linux-foundation.org, oleg@redhat.com,
        walter-zh.wu@mediatek.com, frederic@kernel.org,
        kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irq_work: record irq_work_queue() call stack
Message-ID: <YL+uBq8LzXXZsYVf@hirez.programming.kicks-ass.net>
References: <20210331063202.28770-1-qiang.zhang@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210331063202.28770-1-qiang.zhang@windriver.com>
Precedence: bulk

On Wed, Mar 31, 2021 at 02:32:02PM +0800, qiang.zhang@windriver.com wrote:

> @@ -70,6 +70,9 @@ bool irq_work_queue(struct irq_work *work)
>  	if (!irq_work_claim(work))
>  		return false;
>  
> +	/*record irq_work call stack in order to print it in KASAN reports*/
> +	kasan_record_aux_stack(work);
> +
>  	/* Queue the entry and raise the IPI if needed. */
>  	preempt_disable();
>  	__irq_work_queue_local(work);

Thanks for the Cc :/ Also NAK.

I shall go revert this instantly. KASAN is not NMI safe, while
irq_work_queue() is very carefully crafted to be exactly that.