Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: faiyazm=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3680CC4338A
Subject: Re: [PATCH v11] mm: slub: move sysfs slab alloc/free interfaces to
 debugfs
To:     Vlastimil Babka <vbabka@suse.cz>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-mm <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg KH <greg@kroah.com>, glittao@gmail.com,
        vinmenon@codeaurora.org
References: <1623141934-7699-1-git-send-email-faiyazm@codeaurora.org>
 <CAHp75VcwW6RGALAjzcK4W9xy_hDPyFti4cNY_pCwJnjUr+VYVQ@mail.gmail.com>
 <b84892d5-06ed-fdbe-b5b3-0956140573ec@codeaurora.org>
 <78fc8848-bde8-769e-f8e9-6157d232a60f@suse.cz>
From:   Faiyaz Mohammed <faiyazm@codeaurora.org>
Message-ID: <47842d8d-2747-3d0f-8695-122dc23d90e6@codeaurora.org>
Date:   Tue, 8 Jun 2021 23:43:34 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <78fc8848-bde8-769e-f8e9-6157d232a60f@suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/8/2021 11:05 PM, Vlastimil Babka wrote:
> On 6/8/21 7:11 PM, Faiyaz Mohammed wrote:
>>
>>
>> On 6/8/2021 5:20 PM, Andy Shevchenko wrote:
>>> On Tue, Jun 8, 2021 at 11:45 AM Faiyaz Mohammed <faiyazm@codeaurora.org> wrote:
>>>>
>>>> alloc_calls and free_calls implementation in sysfs have two issues,
>>>> one is PAGE_SIZE limitation of sysfs and other is it does not adhere
>>>> to "one value per file" rule.
>>>>
>>>> To overcome this issues, move the alloc_calls and free_calls
>>>> implementation to debugfs.
>>>>
>>>> Debugfs cache will be created if SLAB_STORE_USER flag is set.
>>>>
>>>> Rename the alloc_calls/free_calls to alloc_traces/free_traces,
>>>> to be inline with what it does.
>>>>
>>>> Signed-off-by: Faiyaz Mohammed <faiyazm@codeaurora.org>
>>>> ---
>>>
>>> It seems you missed the version bump along with changelog.
>>> Note, some maintainers (actually quite many I think) are using tools
>>> to fetch up the patches and two patches with the same version is a
>>> problem. Hence I do not consider it a nit-pick.
>>>
>> Hmmm, I think to avoid same version problem I have to push same patch
>> with new version number and thank you for your patience.
> 
> I *think* Andrew wouldn't have this issue, so maybe resend only if he says it's
> needed.
Sure, I will send if he ask.
> On the other hand I did have troubles to apply the last version locally, patch
> (tool) complained of patch (file) being malformed at the end. Did you add or
> delete lines from it after generating the patch? I had to use the recountdiff
Yes, I added one line manually, I think that causes the issue.

> tool to fix this. If you're going to resend, please make sure it's without the
> same issue.
> 
Okay

>> Thanks and regards,
>> Mohammed Faiyaz
>>
>