Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4795743pxj; Wed, 9 Jun 2021 01:56:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxC/adoyGY0iVkoVWWHGCJqF1GN7HfBcLrHEnxgH8jQJgvpG8iaOn4+7ktFww8CXLCHamIT X-Received: by 2002:a17:906:d1d2:: with SMTP id bs18mr28075599ejb.56.1623228970564; Wed, 09 Jun 2021 01:56:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623228970; cv=none; d=google.com; s=arc-20160816; b=QSiR4kXjp7YCt1SeFmLjfYhoKs4ECCJ36gYLKYWJVWPM59M/e7waPRStRVNQ7bf5yU TYbXkrKzeCzNtk7ysKOfGwee7oR+NPUMQOsEQQLJLDKOh3Vy31Ls2lcPugLv9h/dn45Q m8ZYGvM+3akp9ap6fbpRmQke/HWeTPfnh4fUAr680VM5wmaZJLhVEZsEjdHnX7yDena6 NlTKdpyud+F3H5wiqRdrnbV9GHZcZL4/w80g2HxyQxd2jzDpY3hPLOcLrSvW832Yo42J rQq8AESKKTEL0CbwYPnpj6+XHrtjhM68gPJrvw8Gt4MQxOPRkGZiCR9wHk0CAs0a58jq qydg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=sCTsDfy41C7zyumWEUAlMopOiJs0jW9a3p0GQxFVLjU=; b=OKJuwbktBRY4G3XHdhSIwLI7fJ2hyy89fJD8pCPHGdVSCYcqFqi3aOgd+hi93XZVpt 2UsrtOmk+waJBrhXTRVBpuADh4XADjm196yGTRW/SVkXDsirMdJC7k1fSZEgOhlX/xPB rEe3PCYr1ptgPiD9QYNdUTTpRFuM/GaXAXKxzpUg4v47zNZKOBzAjQZNpbZN1gQc8CrP 9cfGD3b261HfLxO1cLTvSRlpjSY4j+PE6IsAookvx+tmCQ8jmVoPYSzqLPx6NDF1P/+R iElDBcXz5/WqhwSZX3cqEJDHS5Zq1wdujPuHVC8tki/SBPJE8Sl/GiEY69Zsx9/A1bzE IcZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c10si2170276edn.209.2021.06.09.01.55.47; Wed, 09 Jun 2021 01:56:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233972AbhFHRzl (ORCPT + 99 others); Tue, 8 Jun 2021 13:55:41 -0400 Received: from mga01.intel.com ([192.55.52.88]:27341 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233870AbhFHRzk (ORCPT ); Tue, 8 Jun 2021 13:55:40 -0400 IronPort-SDR: pkiVKGJ1uOTvevCU1Dla2Txec7JyI5BYcbSXW1orYteeqKpgdSrKz5X1mEj5auytdRavoQFotB 54G4akolHiVw== X-IronPort-AV: E=McAfee;i="6200,9189,10009"; a="226253591" X-IronPort-AV: E=Sophos;i="5.83,258,1616482800"; d="scan'208";a="226253591" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2021 10:53:47 -0700 IronPort-SDR: mVyXRWAFrZrf+GpBCi3mRgr+6P4Ol+zuGZYKbCM8nM2Sr2ARLOygNXTDldNF+sDWMR+JWgmfBD u+2XzNzfY8Lw== X-IronPort-AV: E=Sophos;i="5.83,258,1616482800"; d="scan'208";a="637719012" Received: from ciball-mobl1.amr.corp.intel.com (HELO [10.252.140.48]) ([10.252.140.48]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2021 10:53:46 -0700 Subject: Re: [RFC v2 08/32] x86/traps: Add #VE support for TDX guest To: Sean Christopherson Cc: Kuppuswamy Sathyanarayanan , Peter Zijlstra , Andy Lutomirski , Dan Williams , Tony Luck , Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Raj Ashok , linux-kernel@vger.kernel.org References: <8a1d6930f784cb57c957cf20cea870947db91e05.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <42f6b603-7c21-28fa-b6ec-e53268aa6ff7@intel.com> Date: Tue, 8 Jun 2021 10:53:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/8/21 10:48 AM, Sean Christopherson wrote: > On Tue, Jun 08, 2021, Dave Hansen wrote: >> On 4/26/21 11:01 AM, Kuppuswamy Sathyanarayanan wrote: >>> +#ifdef CONFIG_INTEL_TDX_GUEST >>> +DEFINE_IDTENTRY(exc_virtualization_exception) >>> +{ >>> + struct ve_info ve; >>> + int ret; >>> + >>> + RCU_LOCKDEP_WARN(!rcu_is_watching(), "entry code didn't wake RCU"); >>> + >>> + /* >>> + * Consume #VE info before re-enabling interrupts. It will be >>> + * re-enabled after executing the TDGETVEINFO TDCALL. >>> + */ >>> + ret = tdg_get_ve_info(&ve); >> Is it safe to have *anything* before the tdg_get_ve_info()? For >> instance, say that RCU_LOCKDEP_WARN() triggers. Will anything in there >> do MMIO? > I doubt it's safe, anything that's doing printing has the potential to trigger > #VE. Even if we can prove it's safe for all possible paths, I can't think of a > reason to allow anything that's not absolutely necessary before retrieving the > #VE info. What about tracing? Can I plop a kprobe in here or turn on ftrace?