Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4828899pxj; Wed, 9 Jun 2021 02:55:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyp+s5CbmypsHPQCCvXlUPRNYUoU4avE3KKFTXkL+2ZlUQG4iMOa7m2vraFNonqt8yJAnBD X-Received: by 2002:a92:dc42:: with SMTP id x2mr17613473ilq.58.1623232540660; Wed, 09 Jun 2021 02:55:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623232540; cv=none; d=google.com; s=arc-20160816; b=KQfaWg3cy5+kQUuKeoj5dTia44ZF2bH3xCnHyCMdgdJD/SraPRK9eR6aUnYQSnq6od pBtCiTpbcO5KtblNcx0U+VE/C+pHvFaEauA/OMQ/1hpaRTdgUIT59RsUK/tQyh7uWPkV 3Be8/mAQOM9WaImDzQxdLPvYuBKhMWO8T/VPvv5MkgAEIyDty1JuoJqwXxZP0vo+LFhJ PMmzSaGD9d0acUNauAWLmwGBaWCTN0fNj7cnCZqaAzXsxBU13yPH2VTrsFdkb/IjZxXY R5H0whwdCcfWM2GHtoQ5mEKucOI64Pv2HGcJhP2LMOA+20qn32mIW+d0ObPbjQ3+7efK 90Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=m1adeyYvXNK4lwIDzR5ghx2Qk0GYUvOPR/5rzF2mxyk=; b=Kf0MFTorVU6Uwod1N90NDbkSkdK+XMpLuKZjovDX5ouw/UVVcPSZDToMlRLaOsJ31i PveFGhW8QHElQuu+ebCbqEYAOczwq4ULrQa4MpZha49IxFCkTKiU7gxr4H+EMWCoAnWL dxT+CX3LOIAnfXI9V0Psl89179oYUPIh+UrIBYz/iNtoNQrbUeqRnki36hC4DfGSMmsZ Q6/FAFCC416vN/9wdDixFnCGYl0K4gl23fmBVPHgwm0GUFqSNJZPsLjlFgEX2A/fZf9t w0gQOkvhKnVmVQPCuOvwuLTdxa6dfPTthLdE3Mbu1W85pcAOy2i/xL3CfdXjLEEOqONe 8Osg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1tplSIxI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y9si3025318jas.84.2021.06.09.02.55.29; Wed, 09 Jun 2021 02:55:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=1tplSIxI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234699AbhFHSrs (ORCPT + 99 others); Tue, 8 Jun 2021 14:47:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:42390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235365AbhFHSnI (ORCPT ); Tue, 8 Jun 2021 14:43:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8644B61442; Tue, 8 Jun 2021 18:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623177361; bh=pd5R80x10t4iMd9B2/849rrCx8yDnlMSlwOZF+OL50w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1tplSIxI5c4QFAgiGhVvYaroEb3327GEMNg//7bWu6bkjWaAS1phKgOtL+VBqZwhH veslqV6F021ZwjQbfFMkak+D75T9Qihss/aizQKiuuRV+QLIqDO65Xkdob30rD31DH NjifgPGYkte7bxmHj9VWpRBedMqTf8QDa4hg9eIg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mitch Williams , Andrew Bowers , Jeff Kirsher , Sasha Levin Subject: [PATCH 5.4 24/78] ice: write register with correct offset Date: Tue, 8 Jun 2021 20:26:53 +0200 Message-Id: <20210608175936.078963999@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210608175935.254388043@linuxfoundation.org> References: <20210608175935.254388043@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mitch Williams [ Upstream commit 395594563b29fbcd8d9a4f0a642484e5d3bb6db1 ] The VF_MBX_ARQLEN register array is per-PF, not global, so we should not use the absolute VF ID as an index. Instead, use the per-PF VF ID. This fixes an issue with VFs on PFs other than 0 not seeing reset. Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c index e92a00a61755..360c0f7e0384 100644 --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c @@ -390,7 +390,7 @@ static void ice_trigger_vf_reset(struct ice_vf *vf, bool is_vflr, bool is_pfr) * by the time we get here. */ if (!is_pfr) - wr32(hw, VF_MBX_ARQLEN(vf_abs_id), 0); + wr32(hw, VF_MBX_ARQLEN(vf->vf_id), 0); /* In the case of a VFLR, the HW has already reset the VF and we * just need to clean up, so don't hit the VFRTRIG register. -- 2.30.2