Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423692AbWKFJ5M (ORCPT ); Mon, 6 Nov 2006 04:57:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423694AbWKFJ5M (ORCPT ); Mon, 6 Nov 2006 04:57:12 -0500 Received: from mtagate6.de.ibm.com ([195.212.29.155]:14698 "EHLO mtagate6.de.ibm.com") by vger.kernel.org with ESMTP id S1423692AbWKFJ5L (ORCPT ); Mon, 6 Nov 2006 04:57:11 -0500 In-Reply-To: <200611060045.59074.arnd@arndb.de> Subject: Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode To: Arnd Bergmann Cc: Christoph Raisch , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, openib-general@openib.org, rolandd@cisco.com X-Mailer: Lotus Notes Release 7.0 HF277 June 21, 2006 Message-ID: From: Hoang-Nam Nguyen Date: Mon, 6 Nov 2006 11:00:00 +0100 X-MIMETrack: Serialize by Router on D12ML065/12/M/IBM(Release 6.5.5HF607 | June 26, 2006) at 06/11/2006 11:00:08 MIME-Version: 1.0 Content-type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 660 Lines: 16 Hi Arnd, > This seems broken. You have a constructor for newly allocated objects, but > there is no destructor and it seems that objects passed to > ehca_free_fw_ctrlblock are not guaranteed to be initialized either. > I'd simply move the memset into the alloc function and get rid of the > constructor here. Yep, I was not aware that ctor is not called for every kmem_cache_alloc(). Thx for pointing this out. Nam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/