Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: o/vO/02tAaL7fz1egTZT1eUaFPG2LPFuAR34d1mE2JcS9VlEumtP6cEaR8qE6Lk/tUDPqy0TIJ
 sNpvpcxPDdnA==
IronPort-SDR: xJ1qcAElwWGhEWhcM5fXsZS1nHvrSVWAPejfMHtuqUT7GWyKf4WAKi1149DFrP9qGfERCG7QSB
 T97+Wkv/Tr8A==
Subject: Re: [RFC v2-fix-v3 1/1] x86/tdx: Skip WBINVD instruction for TDX
 guest
To:     Dave Hansen <dave.hansen@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Tony Luck <tony.luck@intel.com>,
        Dan Williams <dan.j.williams@intel.com>
Cc:     Andi Kleen <ak@linux.intel.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
        Raj Ashok <ashok.raj@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        linux-kernel@vger.kernel.org
References: <CAPcyv4jQ=Fcga3jyUzthjPW9O962vhy3L5XUM6jqR5Z_Zq83LQ@mail.gmail.com>
 <20210608213527.739474-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <ec55256c-3a44-5265-fea8-018a229e92da@intel.com>
From:   "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
Message-ID: <bc41d48e-b001-f870-e421-7c5cbc6ec1c4@linux.intel.com>
Date:   Tue, 8 Jun 2021 15:36:27 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <ec55256c-3a44-5265-fea8-018a229e92da@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/8/21 3:17 PM, Dave Hansen wrote:
> On 6/8/21 2:35 PM, Kuppuswamy Sathyanarayanan wrote:
>> Persistent memory is also currently not supported. Another code
>> path that uses WBINVD is the MTRR driver, but EPT/virtualization
>> always disables MTRRs so those are not needed. This all implies
>> WBINVD is not needed with current TDX.
> 
> It's one thing to declare something unsupported.  It's quite another to
> declare it unsupported and then back it up with code to ensure that any
> attempted use is thwarted.

Only audited and supported drivers will be allowed to enumerate after
device filter support patch is merged. Till we merge that patch, If
any of these unsupported features (with WBINVD usage) are enabled in TDX,
it will lead to sigfault (due to unhandled #VE).

In this patch we only create exception for ACPI sleep driver code. If
commit log is confusing, I can remove information about other unsupported
feature (with WBINVD usage).

> 
> This patch certainly shows us half of the solution.  But, to be
> complete, we also need to see the other half: where is the patch or
> documentation for why it is not *possible* to encounter persistent
> memory in a TDX guest?
> 
> BTW, "persistent memory" is much more than Intel Optane DCPMM.
> 

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer