Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4974363pxj; Wed, 9 Jun 2021 06:31:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsMqGnYBadS7m+UYZfALpDv0BVlExw2Aj5HP/8sIHbzLvc0mUZiSLOJ4HesGofG6EI6Lxw X-Received: by 2002:a17:906:81da:: with SMTP id e26mr15712887ejx.370.1623245485340; Wed, 09 Jun 2021 06:31:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623245485; cv=none; d=google.com; s=arc-20160816; b=iwHFIicXVwwuC+PoIYy7G5D4F17GL+dT6aW0rF5FLb2wFwUZPeSVY48hm60oE9k+m/ L7cx13jD1c0HAFx2lzKOqMvPUeVu7i74jTaySTwehJpRWbnRwMSOdG3F/3/i57HS2rIx YhZIXUW3vnwqoK+86rgoue9/BoMjwpDQ56zBpAP4razG4PHzO7ukaxxbi39uwW+g41AH 9AGsG+ECGPdpcGdfe/BoVLsV62V2TU6ap+ocESodiBNTlvRNzE4CaJUrh2qxToDP+Qz8 MGtPd7bPELrCXg5K4EbJFB/pZyusrXZ/VgjjnhAnoV7lGYe200FKT5ewp7yixyRQID2b JEpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=lLmmry4Ppkn6wdMuC8i0V8N5vknu1eGgzIlC/k3keOE=; b=hlfd2r7OpvsiFXRvfYTa/HlPX52MuhAzglHz+b2LacQKYTPlacSyei+10jp0cmDGl/ lp6a/lnt718/07HUrAjJF02mOg7bLir1jLCinixB2OlC6er2li70gx7jurFl101RJaKF yWOksqMcqJFgFu09bSRVhxo8NRUvaLgqHP6URmGOaeVM45H1b5DvgWWgtQxzgeWkFht2 JQk75oTgA8D8RJQWn8b1hxAQbjQOLlrHW9wJ8mqJk3c6YVszsmhLC+0ajHB9HK3THR1W ITES307dNQj1QQhA23BlkBXW2mYLhtyUUUGt1jMAvXzj9K2L9B8NVg5GdeGeKCwFiQxy NLww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p1si2406751edw.127.2021.06.09.06.31.00; Wed, 09 Jun 2021 06:31:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237101AbhFIHQK (ORCPT + 99 others); Wed, 9 Jun 2021 03:16:10 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:5464 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232746AbhFIHQJ (ORCPT ); Wed, 9 Jun 2021 03:16:09 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G0JDq3mfvzZfWx; Wed, 9 Jun 2021 15:11:23 +0800 (CST) Received: from dggpeml500020.china.huawei.com (7.185.36.88) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 9 Jun 2021 15:14:13 +0800 Received: from huawei.com (10.175.127.227) by dggpeml500020.china.huawei.com (7.185.36.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 9 Jun 2021 15:14:12 +0800 From: Baokun Li To: , Nilesh Javali , , "James E.J. Bottomley" , "Martin K. Petersen" CC: , , , , , , , Hulk Robot Subject: [PATCH -next v2] scsi: qla2xxx: Use list_move_tail instead of list_del/list_add_tail in qla_target.c Date: Wed, 9 Jun 2021 15:23:21 +0800 Message-ID: <20210609072321.1356896-1-libaokun1@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500020.china.huawei.com (7.185.36.88) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using list_move_tail() instead of list_del() + list_add_tail() in qla_target.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li --- V1->V2: CC mailist drivers/scsi/qla2xxx/qla_target.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 12a6848ade43..eb47140a899f 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -5481,8 +5481,7 @@ qlt_free_qfull_cmds(struct qla_qpair *qpair) "%s: Unexpected cmd in QFull list %p\n", __func__, cmd); - list_del(&cmd->cmd_list); - list_add_tail(&cmd->cmd_list, &free_list); + list_move_tail(&cmd->cmd_list, &free_list); /* piggy back on hardware_lock for protection */ vha->hw->tgt.num_qfull_cmds_alloc--;