Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Az2widXAzVqt2LMZU7QdAT4h3RWDv1XlFS36QUXQ4lsAeCcsXa7jS38xrCCMCRra9x2vKcXDL/
 lmqQFRivuPMw==
IronPort-SDR: PFd3i6KK743/tq3npJaexSx+N7YLLYHWZzbadclXJ5v6GicPi5RIYi/rz1d7xzFEttD3PYqYP6
 sJJsVtHQZ2SA==
Cc:     baolu.lu@linux.intel.com, dwmw2@infradead.org, joro@8bytes.org,
        will@kernel.org, yian.chen@intel.com, sohil.mehta@intel.com,
        ravi.v.shankar@intel.com, ashok.raj@intel.com
Subject: Re: [PATCH] iommu/vt-d: Dump DMAR translation structure
To:     Kyung Min Park <kyung.min.park@intel.com>,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
References: <20210526233549.31569-1-kyung.min.park@intel.com>
From:   Lu Baolu <baolu.lu@linux.intel.com>
Message-ID: <13351083-2929-046b-0538-4f760ee89571@linux.intel.com>
Date:   Wed, 9 Jun 2021 15:47:36 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210526233549.31569-1-kyung.min.park@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/27/21 7:35 AM, Kyung Min Park wrote:
> When the dmar translation fault happens, the kernel prints a single line
> fault reason with corresponding hexadecimal code defined in the Intel VT-d
> specification.
> 
> Currently, when user wants to debug the translation fault in detail,
> debugfs is used for dumping the dmar_translation_struct, which is not
> available when the kernel failed to boot.
> 
> Dump the DMAR translation structure, pagewalk the IO page table and print
> the page table entry when the fault happens.
> 
> Signed-off-by: Kyung Min Park <kyung.min.park@intel.com>

Please fix below compile error:

ld: drivers/iommu/intel/dmar.o: in function `dmar_fault_do_one':
/home/allen/Workspace/iommu/drivers/iommu/intel/dmar.c:1965: undefined 
reference to `dmar_fault_dump_ptes'
make: *** [Makefile:1191: vmlinux] Error 1

Best regards,
baolu