Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210517173314.140912-1-gene.chen.richtek@gmail.com> <20210517173314.140912-5-gene.chen.richtek@gmail.com>
In-Reply-To: <20210517173314.140912-5-gene.chen.richtek@gmail.com>
From:   Fei Shao <fshao@chromium.org>
Date:   Wed, 9 Jun 2021 17:48:21 +0800
Message-ID: <CAC=S1njg1PUAkz+TvbtPPxm4uDb3xDSA5HmOOgjwrLz01vFzHw@mail.gmail.com>
Subject: Re: [PATCH v8 04/10] mfd: mt6360: Combine mt6360 pmic/ldo resources
 into mt6360 regulator resources
To:     Gene Chen <gene.chen.richtek@gmail.com>
Cc:     lee.jones@linaro.org, Matthias Brugger <matthias.bgg@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        gene_chen@richtek.com, Wilma.Wu@mediatek.com,
        shufan_lee@richtek.com, cy_huang@richtek.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 18, 2021 at 1:34 AM Gene Chen <gene.chen.richtek@gmail.com> wrote:
>
> From: Gene Chen <gene_chen@richtek.com>
>
> Combine mt6360 pmic/ldo resources into mt6360 regulator resources
> to simplify the similar resources object.
>
> Signed-off-by: Gene Chen <gene_chen@richtek.com>
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/mfd/mt6360-core.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
> index 512480f7bd40..3553c7045829 100644
> --- a/drivers/mfd/mt6360-core.c
> +++ b/drivers/mfd/mt6360-core.c
> @@ -266,7 +266,7 @@ static const struct resource mt6360_led_resources[] = {
>         DEFINE_RES_IRQ_NAMED(MT6360_FLED1_STRB_TO_EVT, "fled1_strb_to_evt"),
>  };
>
> -static const struct resource mt6360_pmic_resources[] = {
> +static const struct resource mt6360_regulator_resources[] = {
>         DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_PGB_EVT, "buck1_pgb_evt"),
>         DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_OC_EVT, "buck1_oc_evt"),
>         DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_OV_EVT, "buck1_ov_evt"),
> @@ -279,9 +279,6 @@ static const struct resource mt6360_pmic_resources[] = {
>         DEFINE_RES_IRQ_NAMED(MT6360_LDO7_OC_EVT, "ldo7_oc_evt"),
>         DEFINE_RES_IRQ_NAMED(MT6360_LDO6_PGB_EVT, "ldo6_pgb_evt"),
>         DEFINE_RES_IRQ_NAMED(MT6360_LDO7_PGB_EVT, "ldo7_pgb_evt"),

Nit: sort MT6360_LDO*_OC_EVT and MT6360_LDO*_PGB_EVT after combining
the resources.

>
> -};
> -
> -static const struct resource mt6360_ldo_resources[] = {
>         DEFINE_RES_IRQ_NAMED(MT6360_LDO1_OC_EVT, "ldo1_oc_evt"),
>         DEFINE_RES_IRQ_NAMED(MT6360_LDO2_OC_EVT, "ldo2_oc_evt"),
>         DEFINE_RES_IRQ_NAMED(MT6360_LDO3_OC_EVT, "ldo3_oc_evt"),
> @@ -299,10 +296,7 @@ static const struct mfd_cell mt6360_devs[] = {
>                     NULL, 0, 0, "mediatek,mt6360-chg"),
>         MFD_CELL_OF("mt6360-led", mt6360_led_resources,
>                     NULL, 0, 0, "mediatek,mt6360-led"),
> -       MFD_CELL_OF("mt6360-pmic", mt6360_pmic_resources,
> -                   NULL, 0, 0, "mediatek,mt6360-pmic"),
> -       MFD_CELL_OF("mt6360-ldo", mt6360_ldo_resources,
> -                   NULL, 0, 0, "mediatek,mt6360-ldo"),
> +       MFD_CELL_RES("mt6360-regulator", mt6360_regulator_resources),
>         MFD_CELL_OF("mt6360-tcpc", NULL,
>                     NULL, 0, 0, "mediatek,mt6360-tcpc"),
>  };
> --
> 2.25.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek