Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   He Ying <heying24@huawei.com>
To:     <pablo@netfilter.org>, <kadlec@netfilter.org>, <fw@strlen.de>,
        <davem@davemloft.net>, <kuba@kernel.org>
CC:     <netfilter-devel@vger.kernel.org>, <coreteam@netfilter.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <heying24@huawei.com>
Subject: [PATCH -next] netfilter: Make NETFILTER_NETLINK_HOOK depends on NF_TABLES
Date:   Wed, 9 Jun 2021 05:57:30 -0400
Message-ID: <20210609095730.185982-1-heying24@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

Compiling errors happen when CONFIG_NETFILTER_NETLINK_HOOK = y
while CONFIG_NF_TABLES is not set:

net/netfilter/nfnetlink_hook.c: In function ‘nfnl_hook_put_nft_chain_info’:
net/netfilter/nfnetlink_hook.c:76:7: error: implicit declaration of function
‘nft_is_active’ [-Werror=implicit-function-declaration]
   76 |  if (!nft_is_active(net, chain))
      |       ^~~~~~~~~~~~~

Notice that nft_is_active macro is only defined when CONFIG_NF_TABLES
is enabled, so add dependency on NF_TABLES in NETFILTER_NETLINK_HOOK
configurations.

Fixes: e2cf17d3774c ("netfilter: add new hook nfnl subsystem")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: He Ying <heying24@huawei.com>
---
 net/netfilter/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index c81321372198..54395266339d 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -22,6 +22,7 @@ config NETFILTER_FAMILY_ARP
 config NETFILTER_NETLINK_HOOK
 	tristate "Netfilter base hook dump support"
 	depends on NETFILTER_ADVANCED
+	depends on NF_TABLES
 	select NETFILTER_NETLINK
 	help
 	  If this option is enabled, the kernel will include support
-- 
2.17.1