Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5046686pxj; Wed, 9 Jun 2021 08:01:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwre+EA7M8JeeWlVIvlIkLv1TvRAVrCCAXMJGwAeDJOTdOEuEN8JwjqBBkf85hHcTUpBxxi X-Received: by 2002:a17:906:b6c5:: with SMTP id ec5mr310059ejb.290.1623250865534; Wed, 09 Jun 2021 08:01:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623250865; cv=none; d=google.com; s=arc-20160816; b=YkUcAvnTBjlIJozF+AengvQOjtIXwOuTyxRSvBoF8808k+L3MpMdZ+Kk5QM7UtDmc1 rAYL5qwu9F3thLtN2iHHmLelcDY0GZA0Uq2hT7VJBYYYz8arNfdfARfeh55BQQ3E1xCF Z+txapcLTyl+/4tG/zm07PCkGlHfoRqiqcP2GDTga2x3erjOTiYSFG72uIvo8V2nEywc m7GUMQMxXwrw0r06r48Ib2Ne2kFQhSgI6h+clF1NEhcMxR1niUfr5zq0Cxgac6yzt2+7 cxCS5mY8iJcQl2IlQ4c0AZ34khbnvWtc40vRxVlEL2kbnSTnIIecbsO/j+qJPkTTWLhF xuOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=raI3uOeCjU5YEVYrGk+yYuKWbJjD6RIAmJ9xbYku34c=; b=g1dn8fotNbaFjDVBH7gPfT+OXpyO1Spzx46Q0Ae2adWEDcOgQ8BJ+lzhNKvsqwUQkU PU9N66MpQvsQlKjo7Qzfz9uXGnAoO2MZqPPnJVAGdtLfzm2ak0hqLQEAua2c2o6STfd7 JNcB+HNMWSVfzYt0Lctwz73rK5coWMHsWrkvGaxRza+p41LNOtibd404AOIRGKhwBU88 E8RUAooVs6C2l4+r2wDHWR5sVKN4mclEsziUo3yVBiv4d/AARxc/Wt2LlsJ3vJ8P/CcM lNqTWzX5zgnJjEV699Cf82gfQwMYdbTQcHHfdtECdKwYY4Gku7TJ/PURgrw8KT6PzB83 5fyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qk15si22954ejb.749.2021.06.09.08.00.41; Wed, 09 Jun 2021 08:01:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234333AbhFIMCs (ORCPT + 99 others); Wed, 9 Jun 2021 08:02:48 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:40651 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231928AbhFIMCq (ORCPT ); Wed, 9 Jun 2021 08:02:46 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lqwt9-0007jn-2h; Wed, 09 Jun 2021 12:00:51 +0000 From: Colin King To: Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] rtc: v3020: remove redundant initialization of variable retval Date: Wed, 9 Jun 2021 13:00:50 +0100 Message-Id: <20210609120050.185746-1-colin.king@canonical.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variable retval is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/rtc/rtc-v3020.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-v3020.c b/drivers/rtc/rtc-v3020.c index d2da92187d56..4e8341c49f51 100644 --- a/drivers/rtc/rtc-v3020.c +++ b/drivers/rtc/rtc-v3020.c @@ -282,7 +282,7 @@ static int rtc_probe(struct platform_device *pdev) { struct v3020_platform_data *pdata = dev_get_platdata(&pdev->dev); struct v3020 *chip; - int retval = -EBUSY; + int retval; int i; chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL); -- 2.31.1