Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <ba7ef002d610ff5b5fc2c31411a1009587e2f068.camel@svanheule.net>
Subject: Re: [PATCH 1/2] Revert "regmap: mdio: Add clause-45 support"
From:   Sander Vanheule <sander@svanheule.net>
To:     Mark Brown <broonie@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Adrew Lunn <andrew@lunn.ch>
Date:   Wed, 09 Jun 2021 14:42:06 +0200
In-Reply-To: <20210609122401.GA20286@sirena.org.uk>
References: <cover.1623238313.git.sander@svanheule.net>
         <deed937f8fd63285e95acdfa8ca327638057811f.1623238313.git.sander@svanheule.net>
         <20210609122401.GA20286@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2021-06-09 at 13:24 +0100, Mark Brown wrote:
> On Wed, Jun 09, 2021 at 01:46:05PM +0200, Sander Vanheule wrote:
> > This reverts commit f083be9db060fbac09123d80bdffb2c001ac0e2b.
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

I had grepped the commit log for other reverting patches, which also appear to
use this style, but I didn't check the regmap-specific ones.


> > There are currently no (planned) regmap users for C45 register access.
> > Remove support for now, to reduce dead code.
> 
> This then creates a bootstrapping issue for anyone who does need it - I
> can't see any way in which this causes problems or gets in the way?

If you would rather keep this, I should modify the other patch (regmap: mdio:
Reject invalid clause-22 addresses) to also cover C45 addresses.
Furthermore, there's an issue with a pointer const-ness in __regmap_init_mdio
that needs to be fixed if this code is staying.

I'll submit a v2 that fixes __regmap_init_mdio, and also applies the address
checks to C45 access.

Best,
Sander