Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am64-main: Update the location of
 ATF in SRAM and increase its max size
To:     Lokesh Vutla <lokeshvutla@ti.com>
CC:     Vignesh Raghavendra <vigneshr@ti.com>, Suman Anna <s-anna@ti.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20210607133806.18158-1-a-govindraju@ti.com>
 <e53458a9-e5f6-6507-f95c-2406b47b5576@ti.com>
From:   Aswath Govindraju <a-govindraju@ti.com>
Message-ID: <b709d5a8-17dd-37e7-405a-35f39f84878b@ti.com>
Date:   Wed, 9 Jun 2021 20:52:07 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <e53458a9-e5f6-6507-f95c-2406b47b5576@ti.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Lokesh,

On 09/06/21 7:59 pm, Lokesh Vutla wrote:
> 
> 
> On 07/06/21 7:08 pm, Aswath Govindraju wrote:
>> Due to a limitation for USB DFU boot mode, SPL load address has to be less
>> than  or equal to 0x70001000. So, load address of SPL and ATF have been
>> moved to 0x70000000 and 0x701a0000 respectively.
>>
>> Also, the maximum size of ATF has been increased to 0x1c000 [1].
>>
>> Therefore, update ATF's location and maximum size accordingly in the device
>> tree file.
>>
>> [1] - https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=2fb5312f61a7de8b7a70e1639199c4f14a10b6f9
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
>> index ca59d1f711f8..fcd12b6f10f6 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
>> @@ -13,8 +13,8 @@
>>  		#size-cells = <1>;
>>  		ranges = <0x0 0x00 0x70000000 0x200000>;
>>  
>> -		atf-sram@0 {
>> -			reg = <0x0 0x1a000>;
>> +		atf-sram@1a0000 {
>> +			reg = <0x1a0000 0x1c000>;
> 
> After thinking a bot more, isn't size be 0x20000?
> ATF is allocated with 125KB no? no point keeping the ~3 as hole IMO.
> 

The max size of ATF as defined above in [1] is 0x1c000 and as the
argument has to reflect it I have modified it to the same.

Thanks,
Aswath


> Thanks and regards,
> Lokesh
> 
>>  		};
>>  	};
>>  
>>