Subject: Re: [PATCH] add pci revision id to struct pci_dev
From: Arjan van de Ven <arjan@infradead.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Conke Hu <conke.hu@gmail.com>, linux-kernel@vger.kernel.org
In-Reply-To: <1162819681.1566.63.camel@localhost.localdomain>
References: <5767b9100611060440i1149e0e3v2162e0604db10da7@mail.gmail.com>
	 <1162819681.1566.63.camel@localhost.localdomain>
Content-Type: text/plain
Organization: Intel International BV
Date: Mon, 06 Nov 2006 15:19:17 +0100
Message-Id: <1162822757.3138.32.camel@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1073
Lines: 24

On Mon, 2006-11-06 at 13:28 +0000, Alan Cox wrote:
> Ar Llu, 2006-11-06 am 20:40 +0800, ysgrifennodd Conke Hu:
> > Hi all,
> >     PCI revision id had better be added to struct pci_dev and
> > initialized in pci_scan_device.
> 
> You can read the revision any time you like, we don't need to cache a
> copy as we don't reference it very often

one consideration is that if you read it from the hw you can't actually
fix it up in quirks at all, so it might make a lot of sense to just also
store it in the pci device struct, it's a very logical thing esp since
the pci device/vendor ids are stored there too (and those you can also
read from the hw if you want ;)

-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/