Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1a6306bb029779e26d92ba3e2608e500ce47c6f7.camel@gmail.com>
Subject: Re: [RFC PATCH 1/1] arm64: implement live patching
From:   Suraj Jitindar Singh <sjitindarsingh@gmail.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        live-patching@vger.kernel.org, catalin.marinas@arm.com,
        will@kernel.org, mark.rutland@arm.com,
        madvenka@linux.microsoft.com, duwe@lst.de, benh@kernel.crashing.org
Date:   Tue, 08 Jun 2021 17:12:15 -0700
In-Reply-To: <20210607170154.GC10625@sirena.org.uk>
References: <20210604235930.603-1-surajjs@amazon.com>
         <20210607170154.GC10625@sirena.org.uk>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-06-07 at 18:01 +0100, Mark Brown wrote:
> On Fri, Jun 04, 2021 at 04:59:30PM -0700, Suraj Jitindar Singh wrote:
> 
> > + * CONFIG_ARM64_BTI_KERNEL:
> > + *	- Inserts a hint #0x22 on function entry if the function is
> > called
> > + *	  indirectly (to satisfy BTI requirements), which is inserted
> > before
> > + *	  the two nops from above.
> 
> Please write out the symbolic name of the HINT (BTI C here) rather
> than
> the number, it helps with readability especially in a case like this
> where there are multiple relevant hints.

Thanks for taking a look, I will keep that in mind for when I resend.