Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5137245pxj; Wed, 9 Jun 2021 09:59:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYPzTsvfO+rCWaeub0+c7YioFai7Iau/S/c+ZZkxR1MWMzgleMEbPWjf3LYyHq8S9cFB0T X-Received: by 2002:aa7:d158:: with SMTP id r24mr376336edo.171.1623257967252; Wed, 09 Jun 2021 09:59:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623257967; cv=none; d=google.com; s=arc-20160816; b=V015Yvo/QAJFVM9YN7iMXIRS9fr2tqNzTs5BeucIuJmXQAXXabLv7OphjyxGZRx+vs ZjkZNDbUY5Ei+NTo+jgxANYZjALYW2VjrkP47pmoV00JgaxsZa1e1kOqzvanXtT/Wr1W PvIhTDrvo5ai9M4zykuVPcX5dOmeUFSDGpCO6Uk17iivP+1+FsFH8n6fU8Qn1XqZOWMg SwQbj/M1BH7Wr9lWLyVilJz06Lx2/9RZ6I8Yt7t9e7TiOGsa+Ki3oDm8C72aluzM7DsM 9YONSt+4PYqffSENtCM0OxOrpNDdmBu/pWvBUGVqfiXGFKvBr6fkWcCukXGEMGKwQwzB bX5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=5JBAZzJaCjRZvxuxVXPvwqadmec7A5vRTpyuqn1VcQQ=; b=NFfmm/VH2rxjbzUhFnkK/pZtP8gmqI1z7DS9bKYmf//WVPmNwjcw/wdYuPCBer3e1o EPZc3x3IWy5HG24ZaOBaKUtmaY6ydk7c5qIzAInxLvXx5RTshT0Jn+KYYITOh7B+t4eC ajfJT4ImtE75qTiH8TFmehMN6zi2PRHmqaT08fwocFC/IBpL1q9gnTPgd9uCGm4D9suW /cbuD4Bo+P2CLOidLS4Y2dxj/3E/fMUvZGaviCFoo6Lu4U1pDUp0MZe9l8KEX/vv39+l 8fszO3a+VdlkFT5xx6ithx2U4JsOAEKuEfv8N43dVv1nf/gd07TaCC8txiNK8/6Zjx+H 8DYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i7si298030ejo.265.2021.06.09.09.59.02; Wed, 09 Jun 2021 09:59:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231923AbhFIAFI (ORCPT + 99 others); Tue, 8 Jun 2021 20:05:08 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:60757 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231863AbhFIAFG (ORCPT ); Tue, 8 Jun 2021 20:05:06 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 68A3F1BF205; Wed, 9 Jun 2021 00:03:12 +0000 (UTC) From: Alexandre Belloni To: Yang Yingliang , linux-kernel@vger.kernel.org, linux-i3c@lists.infradead.org Cc: Alexandre Belloni , miquel.raynal@bootlin.com Subject: Re: [PATCH -next v2] i3c: master: svc: drop free_irq of devm_request_irq allocated irq Date: Wed, 9 Jun 2021 02:03:10 +0200 Message-Id: <162319698188.1230434.16937256801626257846.b4-ty@bootlin.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210602084935.3977636-1-yangyingliang@huawei.com> References: <20210602084935.3977636-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Jun 2021 16:49:35 +0800, Yang Yingliang wrote: > irq allocated with devm_request_irq() will be freed in devm_irq_release(), > using free_irq() in ->remove() will causes a dangling pointer, and a > subsequent double free. So remove the free_irq() in svc_i3c_master_remove(). Applied, thanks! [1/1] i3c: master: svc: drop free_irq of devm_request_irq allocated irq commit: 59a61e69c4252b4e8ecd15e752b0d2337f0121b7 Best regards, -- Alexandre Belloni