Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5139398pxj;
        Wed, 9 Jun 2021 10:01:42 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyvYaEzCa+t1pgPAH5rWWNA7OodKShad+FclMlZOiNRe52+Ctq7GypqoBxlhxYgpZyONsUb
X-Received: by 2002:a05:6402:1c83:: with SMTP id cy3mr425155edb.108.1623258102467;
        Wed, 09 Jun 2021 10:01:42 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1623258102; cv=none;
        d=google.com; s=arc-20160816;
        b=sb2tRNPx06wp05BsvOAND3uMzFG/bZFuhkrnA7B5BGUQTpyoGCrD1K3a6bMmIHIpBF
         br0OXC/eTV0X9+Rte5Dz4zaYjxoW+URxI2TBqoHpYBLIFQ0+GEWr5NSH+LR2eMTOw2IZ
         FeAcx2H6VvobbIA0DPag8GGTKA/zGaQe7JXMDcQY6acouKKVczQXSeCQv/7PBKvfXXH9
         BeMP5C8dPP/nYoYMDFMYFqzECJRZs5ee1o7RUPXCqXQyCpY5aW7APkunYkltClFLkfdj
         jAjcukCOEB7z7XUgJsS0WiAc12bEh85l9XtdDwHKYCFZdbi0BzuHACD9R6+4Nuj5o8Hg
         Up/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to
         :message-id:mime-version:user-agent:dkim-signature:dkim-signature;
        bh=UEXUkaEiFQLjUvGmFiXJYNKYLn4GSKfTv6e4CZYJsGQ=;
        b=r5oRtWSrx5QHsz84WcZPucVMursYp+dNljYcLbPzo8YJvSH9QU93PJZp4YdNI3z9YM
         lwnkYs9PjrzQ3GxUPvaQVxggo/tvuXwdWrZKJJSHfBxJfEYuCsORY36psSYg3SespRJq
         hLfzjkGu1WFUGQqKL/AbFX0dKxDCeNR8KdnIERmccqBEMr6+rHOpSfeLJkUulatRbQSk
         +KdBlvkrBXt1052LCFtPzOhChbKuzkgf2405/qSUp+g0yAC8T6i1K6SPq1vxwnx+hOGU
         8ea4WV+RP3ikeb5dwVGF08CWuZ/m1iIy0vwb673UuN85DTdokOuG8WS0JDKvaG3aep3i
         neMA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@aj.id.au header.s=fm3 header.b=TCl987RP;
       dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=LpY8IeH5;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id hp35si297344ejc.731.2021.06.09.10.01.18;
        Wed, 09 Jun 2021 10:01:42 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@aj.id.au header.s=fm3 header.b=TCl987RP;
       dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=LpY8IeH5;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235358AbhFIA61 (ORCPT <rfc822;luscent@gmail.com> + 99 others);
        Tue, 8 Jun 2021 20:58:27 -0400
Received: from new4-smtp.messagingengine.com ([66.111.4.230]:42415 "EHLO
        new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S232076AbhFIA6Z (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 8 Jun 2021 20:58:25 -0400
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
        by mailnew.nyi.internal (Postfix) with ESMTP id 032DA580922;
        Tue,  8 Jun 2021 20:56:32 -0400 (EDT)
Received: from imap43 ([10.202.2.93])
  by compute2.internal (MEProxy); Tue, 08 Jun 2021 20:56:32 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=
        mime-version:message-id:in-reply-to:references:date:from:to:cc
        :subject:content-type; s=fm3; bh=UEXUkaEiFQLjUvGmFiXJYNKYLn4GSKf
        Tv6e4CZYJsGQ=; b=TCl987RPTWC88e5PPQSgE+1qbePmZ/8iS6PC3qlnAMVXwGb
        ypLi0vQyfxhS4QW0Ya9NpzGB1C/UQ6JjgJCvfYnl0S157z+nPod0VRiYfF5ioeV9
        n/FtqPmGqrlSwR/14hPpX86Ji2iCOt5Q7GvlsMW179xr4sPCfMjnTinvvdh4HY08
        RClDdQck+TLWsNgYMcoPZFHJaamZBUVcuzjNV1FiftvY32vgmoMb5Tg+MBHY0M6q
        ldJD3VCm7r0M7jeypdo4ZeuMb7614S/NHVrS216JTPj3Dh3V0xlW4CxAthe2pQuQ
        U+1T4JTCfHfhyPXdoTCLYimwGvseovIAUfk/JVw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
        messagingengine.com; h=cc:content-type:date:from:in-reply-to
        :message-id:mime-version:references:subject:to:x-me-proxy
        :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=UEXUka
        EiFQLjUvGmFiXJYNKYLn4GSKfTv6e4CZYJsGQ=; b=LpY8IeH51vX0Ts4LZ5c7h0
        TU2+6aHMRaxlx2pzZ2fIOivdgUbyPGcdO9SXrrEybJuL024+LKteiMrBUL4lhlzo
        F+FOoQIkFeluyxqhVnau2Nv9TAeJv/eZ9YFi68DZnxZ1nl986EFaD1JpUvufSkAc
        MBNxo6CpPPSO8Tt1tIjVodi4jye2WM1ZYKEc5ALQ6lvMvjxMfNxZiAk9auqquAfz
        JNEEDdR7k8MZ8XUR0KoZ06ZfTwtO806w24Bee8ee1GDoWffNzP3RRfdj332EakGC
        vZOFVBfPcRGJkwlQhfEeHtTtRwy+RTwRBIMao0f9do1+4WfiUeerNid9BTCDYkHQ
        ==
X-ME-Sender: <xms:vxHAYFhxctgAA3C4xcXS4ppQsJcn4-jv1El4ucwQfLjhFWlD2Zq66g>
    <xme:vxHAYKBupQ_RU5g-KVQm4FKlBUWivq8vPR7pQyVOsm4gtj6laIt3F0HAMRelhH2VA
    Cf_xVvxMmkyAP7EAQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedutddgfeegucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu
    rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf
    grthhtvghrnhepuddttdekueeggedvtddtueekiedutdfguedutdefieeuteefieelteet
    vddthfeinecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh
    eprghnughrvgifsegrjhdrihgurdgruh
X-ME-Proxy: <xmx:vxHAYFEytP3CrsE9oyllP_AFL-UakUpXq0Y808ZD7b8Gshzx9zeCKg>
    <xmx:vxHAYKSefdA0tah_-C2awatNP-9wfRJmtcWYAL1EsLTxI6Iys-0y4g>
    <xmx:vxHAYCyod1UvLXhPm-9alWmlAEcO_IXxRs8gfGffvXMJTJ5tY3ZQ6Q>
    <xmx:wBHAYHqdCOfNkdNosTpvUcQqEvibNwtSvfxmQESAUPaLLsvXieGWPg>
Received: by mailuser.nyi.internal (Postfix, from userid 501)
        id D6CB9AC0062; Tue,  8 Jun 2021 20:56:31 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.5.0-alpha0-519-g27a961944e-fm-20210531.001-g27a96194
Mime-Version: 1.0
Message-Id: <311d0c03-06f3-4c68-aa5a-877a592b6975@www.fastmail.com>
In-Reply-To: <20210608102547.4880-11-steven_lee@aspeedtech.com>
References: <20210608102547.4880-1-steven_lee@aspeedtech.com>
 <20210608102547.4880-11-steven_lee@aspeedtech.com>
Date:   Wed, 09 Jun 2021 10:26:11 +0930
From:   "Andrew Jeffery" <andrew@aj.id.au>
To:     "Steven Lee" <steven_lee@aspeedtech.com>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        "Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Joel Stanley" <joel@jms.id.au>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-aspeed@lists.ozlabs.org>,
        "open list" <linux-kernel@vger.kernel.org>
Cc:     "Hongwei Zhang" <Hongweiz@ami.com>,
        "Ryan Chen" <ryan_chen@aspeedtech.com>,
        "Billy Tsai" <billy_tsai@aspeedtech.com>
Subject: =?UTF-8?Q?Re:_[PATCH_v5_10/10]_gpio:_gpio-aspeed-sgpio:_Return_error_if_?=
 =?UTF-8?Q?ngpios_is_not_multiple_of_8.?=
Content-Type: text/plain
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Tue, 8 Jun 2021, at 19:55, Steven Lee wrote:
> Add an else-if condition in the probe function to check whether ngpios is
> multiple of 8.
> Per AST datasheet, numbers of available serial GPIO pins in Serial GPIO
> Configuration Register must be n bytes. For instance, if n = 1, it means
> AST SoC supports 8 GPIO pins.
> 
> Signed-off-by: Steven Lee <steven_lee@aspeedtech.com>

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>