Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5139505pxj; Wed, 9 Jun 2021 10:01:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgJ+WbN/Xj6S68CmIDrRJhOcxgLXrzDQ7yn0uOQ585ybXJdlWjZKyUTLX9ilUQoaZooEHb X-Received: by 2002:a17:906:c0c7:: with SMTP id bn7mr768885ejb.393.1623258108568; Wed, 09 Jun 2021 10:01:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623258108; cv=none; d=google.com; s=arc-20160816; b=fkYQsS0I/dv1pO9ShSad00BXpodkCBoVoC2KChqry6Uf+F4o4eURTsADQ3PTKSzVPI cbsc26nfZdhhfqkuZH+7d0O1qliv3GLIyLLGi12tA56sABNDW42vDxfLx6YGqSSevfFx ldKKRAsqgV+VKIN6+UTWuwnZzbAqQ4j/Wxj8sOEr3bobNCJ+z6j9Bnsl0eRDaoZ2KwI2 zM5T8syAZUuVRMkrSL+yh29LAp+wWZDIgRTrjOR2EJN64FyDSNEQnQUs013jSYwX8oD6 PZUYAicQDRj8VW3nyvr7eCD28pFwgOs0Zh8rnEP+DzJa/USKfO/vXMpD+OuEuM3txBMu dhJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=weAH7W2k7sl7Rh6AQGNUp5yO/TsqWHgJbyDvmMDkiG8=; b=SiieG6974hhBig4+yzAIno3ZUvyKNvmkYI0OE6UFbkTtKSKjyneZBhjuF8TNqByyO4 otIlhdNqbqdVTLzXreimZkAKWMg0BCXts85//8ydzMsLx/RZI1lrxnBJK/RghCBAuVB9 Z0Yg/icayrLRXEzp3+j7+xDZrphGn/sYqCqP0gbTE8WL9lDyUALPa9FxrAL93CKlmSoq yGcdON2gs8bzbAFxouZrircNeXUtiO9WCvDqqArV2fTNQJQaH21a/3ZSbhmSJTbnf4cf DmfbV7XMXTfePilYa9pNgjyXL4W/nj0/jv2BHn2dRVLiGmOpc96kBecb6/7npjObv+AI FvFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=SZYHTTfa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h7si231050ejo.519.2021.06.09.10.01.23; Wed, 09 Jun 2021 10:01:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=SZYHTTfa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234824AbhFIA15 (ORCPT + 99 others); Tue, 8 Jun 2021 20:27:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:46628 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234717AbhFIA1z (ORCPT ); Tue, 8 Jun 2021 20:27:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F5CF61352; Wed, 9 Jun 2021 00:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1623198345; bh=j6Daa0ANcHXgawdprrhhE9gPp/k5n5R1I8bzEIzLkJ4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SZYHTTfaMcaxuiVLTcleHa9xYaQtKKlW0lSVx8ank0QE87umgBXHwANYgV3RZTaNu rf7Ir5wxGLTzdarw+lfYNOq0SOvDo1l3StstPYzKpK2C8V7G7swvSJ4cooRpaDMdu2 H1uHQBHkLxKC0zrfLh/KxjIWjXc3HCBsO4EPTYqY= Date: Tue, 8 Jun 2021 17:25:44 -0700 From: Andrew Morton To: Mike Rapoport Cc: Arnd Bergmann , Geert Uytterhoeven , Ivan Kokshaysky , Jonathan Corbet , Matt Turner , Mike Rapoport , Richard Henderson , Vineet Gupta , kexec@lists.infradead.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 8/9] mm: replace CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA Message-Id: <20210608172544.d9bf17549565d866fbb18451@linux-foundation.org> In-Reply-To: <20210608091316.3622-9-rppt@kernel.org> References: <20210608091316.3622-1-rppt@kernel.org> <20210608091316.3622-9-rppt@kernel.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Jun 2021 12:13:15 +0300 Mike Rapoport wrote: > From: Mike Rapoport > > After removal of DISCINTIGMEM the NEED_MULTIPLE_NODES and NUMA > configuration options are equivalent. > > Drop CONFIG_NEED_MULTIPLE_NODES and use CONFIG_NUMA instead. > > Done with > > $ sed -i 's/CONFIG_NEED_MULTIPLE_NODES/CONFIG_NUMA/' \ > $(git grep -wl CONFIG_NEED_MULTIPLE_NODES) > $ sed -i 's/NEED_MULTIPLE_NODES/NUMA/' \ > $(git grep -wl NEED_MULTIPLE_NODES) > > with manual tweaks afterwards. > > ... > > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -987,7 +987,7 @@ extern int movable_zone; > #ifdef CONFIG_HIGHMEM > static inline int zone_movable_is_highmem(void) > { > -#ifdef CONFIG_NEED_MULTIPLE_NODES > +#ifdef CONFIG_NUMA > return movable_zone == ZONE_HIGHMEM; > #else > return (ZONE_MOVABLE - 1) == ZONE_HIGHMEM; I dropped this hunk - your "mm/mmzone.h: simplify is_highmem_idx()" removed zone_movable_is_highmem().