Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5140136pxj; Wed, 9 Jun 2021 10:02:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpeSu6cKE8eIbOFRx+Wsh9owZi/LcBrec93hD2xvaw1GyTA7nIIKWCO1RwXwS5zg39S422 X-Received: by 2002:a17:906:365a:: with SMTP id r26mr843902ejb.340.1623258151878; Wed, 09 Jun 2021 10:02:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623258151; cv=none; d=google.com; s=arc-20160816; b=XOk4+uafcZeSeCHTWXVOPqVaeUfkEnFSPzrpo7rJM0oxWQTqkH3ykMwGL2CBzohKOM PET8zmlh19Wx7lTiaMOzk1aRKQBz1McpU5GT4xUahywlAGHjRrELlAWP3eRW+ic20oIT V+HnsP1xjzZWp6aEriCNcYZBcHr9Tzrz92m+PdoFncNHZlCVojNoTLChOtvYowX8vlMH M1HV3mTEa25uA9Nm4YemBLKmaTpKJK86HMpgloq/CB60X/nmDt02VPlhx7/sOvlcKshG 6G/RI3w5PJCGy4aqyL/jVoV/eNTuBunD/Q81gfHXM2Nq8p7jXlG7nnqtsKJYhT0ats0V UB9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=9qeiNnEqHnToVwTF+YALaJhts33Y3hAzDOiNFEpUNqM=; b=XzXrlOZcGXRYci8Zva/Ci6X8FgeHHm2gDwwweGJfPb3f/oxNUhqsvZPN0huoo4y6Jy /nQvTM0Ky3bvzCzD6g9BBVqR1rs1yRRpO8aTuQnXmOBglkEOW1jIqBBnM+KT/xHJSHSH BOZiO5HpigPlNfpHufWMzerRLzFb//dUQbbVAYISsRybYmLVxs91F5w/PNFc13XoOUV0 Ekd3zvvF5mM98Tsv7jwppshkw1DsZ+7laXTw99f1pAKJTEbgAh9ME108s6+GvevF7yLL EcPtDk4t8XpZO57AIwgg0HRogIfdWGD5GoW9NBcKtdGXbra4Ih/BYu9EP6aS6ZXhZnci PaAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=nqsl5TFA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h22si279714ejl.384.2021.06.09.10.02.06; Wed, 09 Jun 2021 10:02:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=nqsl5TFA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235325AbhFIA6s (ORCPT + 99 others); Tue, 8 Jun 2021 20:58:48 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:36705 "EHLO mail-wm1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235327AbhFIA6p (ORCPT ); Tue, 8 Jun 2021 20:58:45 -0400 Received: by mail-wm1-f44.google.com with SMTP id h11-20020a05600c350bb02901b59c28e8b4so2666397wmq.1 for ; Tue, 08 Jun 2021 17:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9qeiNnEqHnToVwTF+YALaJhts33Y3hAzDOiNFEpUNqM=; b=nqsl5TFA6nFViy1WhnYLZii0d/gfdyqbxMgo5ZeCK+zscVoklu4FygICY98Ui//B6f nCqThTZMMhYiHD4SThREyZrFCg+F9BfwGkG4DqwOzwpjwwl7ICQYAkZ/P3DlUE32eBtl npsM7xAJQBoLFsBLrlmr81kRgV5HvHjICWZSA/fZgQBWkdDx/2nHjZU1GQ/Lj6p2IV98 FmmigXGK7Z0E94aqQpyP2g921KQ/vi1edhJoiU6MSqBsPr9zsKXC8FFKOo4R32sUVPuB WWLLPhyl/pILiWvSG9BUxQf+Jkkb0QIyP35vDEmcfqloSOejvDWhu0tJnTMgBQOcc/sy Ovww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9qeiNnEqHnToVwTF+YALaJhts33Y3hAzDOiNFEpUNqM=; b=g1AJT3DXzj9ZqXqcwwmvhlLKCw+VRmfoWO3NwKCLqO/pW3Loq5/EiVSQZpksOK5/51 WzbAN0qr57piOwf7OXyQn8aoAKqqRnEIY7bolsJIc6OPIHVSbjaiXOTPn3N5oRfhmHNQ xGSjSZJn9ISBbsmI3a3SBFe3Kr3t9h0OAf47ZUQsYrNEqgGwvlISvSVN5S1868X+iSr5 UXacQpgFbQS8mBIFA89FPudBkldZeZ5HL2ZBqMYFdjcus2ZRNXiGdrML8Uwx1pGYKz0G m/ooC2yzVRJJwMMPEJeY8fDgro7FdlCxqq0mklfztEhgbEv2eu4kThBMsFZEnumv2mj1 jHcQ== X-Gm-Message-State: AOAM5301ejOr77o+vv/rOdwZbJSkaWkd9Uxa/eGjEM2FU/dRb+9eGruZ 9ZmgFBBoVxQBwbNfsnTA3o58OsqxqtmC7LeL4jXSRQ== X-Received: by 2002:a7b:cbd1:: with SMTP id n17mr25640495wmi.2.1623200151418; Tue, 08 Jun 2021 17:55:51 -0700 (PDT) MIME-Version: 1.0 References: <20210608143159.1.I230026301243fbcee23d408c75aa468c1fec58f7@changeid> In-Reply-To: From: "Anand K. Mistry" Date: Wed, 9 Jun 2021 10:55:38 +1000 Message-ID: Subject: Re: [PATCH] drm/amd/display: Fix error code on failure to set brightness To: Harry Wentland Cc: amd-gfx@lists.freedesktop.org, Alex Deucher , Aurabindo Pillai , Bas Nieuwenhuizen , =?UTF-8?Q?Christian_K=C3=B6nig?= , Daniel Vetter , David Airlie , Eryk Brol , Leo Li , Nicholas Kazlauskas , Nikola Cornij , Qingqing Zhuo , Rodrigo Siqueira , Wayne Lin , DRI Development , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Thanks for your patch but this code has changed on amd-staging-drm-next. > > Can you try with the latest? The new backlight_update_status will always > return 0 now. Perfect! This solves my actual issue which is that restoring the backlight level is failing on my device. Thank you. -- Anand K. Mistry Software Engineer Google Australia