Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210607101634.4948-1-ricky_wu@realtek.com> <CABTNMG1yoYPgs0gr1bHsrxCmpNM8fUB+3S5E+HS7c9pPGiFxrQ@mail.gmail.com>
 <YL8xYRwKfA5EtSqT@kroah.com> <CABTNMG2HZD52DmQ8iqC1jqLf6v4QpqCyxOXgjMjzD7rySgGa7A@mail.gmail.com>
 <YL9t/ZfRsIMSpXfm@kroah.com>
In-Reply-To: <YL9t/ZfRsIMSpXfm@kroah.com>
From:   Chris Chiu <chris.chiu@canonical.com>
Date:   Wed, 9 Jun 2021 11:01:53 +0800
Message-ID: <CABTNMG0PfX=eC0=hyUexoomH83NYzePwVkf4P0FLE05=wSyssQ@mail.gmail.com>
Subject: Re: [PATCH v2] misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Ricky WU <ricky_wu@realtek.com>, arnd@arndb.de,
        Bjorn Helgaas <bhelgaas@google.com>, ulf.hansson@linaro.org,
        rui_feng@realsil.com.cn, vaibhavgupta40@gmail.com,
        yang.lee@linux.alibaba.com,
        Linux Kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 8, 2021 at 9:17 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jun 08, 2021 at 07:16:14PM +0800, Chris Chiu wrote:
> > On Tue, Jun 8, 2021 at 4:59 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Tue, Jun 08, 2021 at 11:43:03AM +0800, Chris Chiu wrote:
> > > > On Mon, Jun 7, 2021 at 6:16 PM <ricky_wu@realtek.com> wrote:
> > > > >
> > > > > From: Ricky Wu <ricky_wu@realtek.com>
> > > > >
> > > > > aspm (Active State Power Management)
> > > > > rtsx_comm_set_aspm: this function is for driver to make sure
> > > > > not enter power saving when processing of init and card_detcct
> > > > > ASPM_MODE_CFG: 8411 5209 5227 5229 5249 5250
> > > > > Change back to use original way to control aspm
> > > > > ASPM_MODE_REG: 5227A 524A 5250A 5260 5261 5228
> > > > > Keep the new way to control aspm
> > > > >
> > > > > Signed-off-by: Ricky Wu <ricky_wu@realtek.com>
> > > > > ---
> > > > Reported-by: Chris Chiu <chris.chiu@canonical.com>

Tested-by: Gordon Lack <gordon.lack@dsl.pipex.com>
Fixes: 121e9c6b5c4c ("misc: rtsx: modify and fix init_hw function")

> > >
> > > Can you test this to verify it works?
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > It's verified and confirmed by the user at comment #17 of
> > https://bugs.launchpad.net/bugs/1929444.
>
> That's not useful to put in a changelog text.  Please respond with a
> real tag that I can use.
>
> thanks,
>
> greg k-h