Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] mmc: sdhci-iproc: Add support for the legacy sdhci
 controller on the BCM7211
To:     Ulf Hansson <ulf.hansson@linaro.org>,
        Al Cooper <alcooperx@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
        DTML <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-mmc <linux-mmc@vger.kernel.org>,
        Nicolas Saenz Julienne <nsaenz@kernel.org>,
        Ray Jui <rjui@broadcom.com>, Rob Herring <robh+dt@kernel.org>,
        Scott Branden <sbranden@broadcom.com>
References: <20210602192758.38735-1-alcooperx@gmail.com>
 <20210602192758.38735-2-alcooperx@gmail.com>
 <CAPDyKFrynST66yA_T3iroiJsfmNuBOEiiBnb=vNoyP6QpvZ7aQ@mail.gmail.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <fe956941-bb39-413e-f051-d9f353f64eda@gmail.com>
Date:   Tue, 8 Jun 2021 20:07:05 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <CAPDyKFrynST66yA_T3iroiJsfmNuBOEiiBnb=vNoyP6QpvZ7aQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/8/2021 5:40 AM, Ulf Hansson wrote:
> On Wed, 2 Jun 2021 at 21:28, Al Cooper <alcooperx@gmail.com> wrote:
>>
>> Add support for the legacy Arasan sdhci controller on the BCM7211 and
>> related SoC's. This includes adding a .shutdown callback to increase
>> the power savings during S5.
> 
> Please split this into two separate changes.
> 
> May I also ask about the ->shutdown() callback and in relation to S5.
> What makes the ->shutdown callback only being invoked for S5?

It is not only called for S5 (entered via poweroff on a prompt) but also
during kexec or reboot. The poweroff path is via:

kernel_power_off() -> kernel_shutdown_prepare() -> device_shutdown() ->
.shutdown()

For kexec or reboot we do not really care about power savings since we
are about to load a new image anyway, however for S5/poweroff we do care
about quiescing the eMMC controller in a way that its clocks and the
eMMC device can be put into low power mode since we will stay in that
mode for seconds/hours/days until someone presses a button on their
remote (or other wake-up sources).
-- 
Florian