Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: oX5rPxONy4qSXk4ezTPzeGTiToeeKg2BI/nCGZ+yf6UyQRKmgCQHusi8NNyjpHrr6GshpQ7TYo
 XztH+QuOAx9w==
IronPort-SDR: CnHLeEBhcNgz2NyLL/DSIPWtc/cAx1WpIR7s09DMJ39lwswXLqZpARCXvJRTDwPxNXCVdqXheD
 jpN3aeGE56UQ==
Subject: Re: [RFC v2-fix-v4 1/1] x86/tdx: Skip WBINVD instruction for TDX
 guest
To:     Andy Lutomirski <luto@kernel.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc:     "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
        Raj Ashok <ashok.raj@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <CAPcyv4iAgXnMmg+Z1cqrgeQUcuQgXZ1WCtAaNmeHuLT_5QArUw@mail.gmail.com>
 <20210609011030.751451-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <CAPcyv4gLeKPfYOx1kmg-mO1_mNd+XGqVO-CbqX+2d52GZ+DSFw@mail.gmail.com>
 <23418f34-7c03-7477-6fbf-1b36b4718cb9@kernel.org>
 <4e5ac34f-28cb-def6-0b87-e560fa42e5e5@linux.intel.com>
 <e9b2aab2-4a6f-4739-a939-c448414e6af2@www.fastmail.com>
From:   Andi Kleen <ak@linux.intel.com>
Message-ID: <390d6712-35b5-e52a-fb32-205844bad4ef@linux.intel.com>
Date:   Tue, 8 Jun 2021 21:40:42 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <e9b2aab2-4a6f-4739-a939-c448414e6af2@www.fastmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


>> KVM only turns it into a noop if there is no VT-d, because with VT-d you
>> might need it to turn mappings into uncached and vice versa.
> Wow, I found the kvm_arch_register_noncoherent_dma() stuff.  That's horrifying.  What's it for?  e

e.g. if you want to run a GPU it really needs some uncached memory. Same 
is true for other more complex devices.

Now modern Linux of course will be preferring CLFLUSH instead for the 
conversion, but there are old versions that preferred WBINVD.

I don't think it's a DoS, as long as you're not too picky about 
latencies on the host.

-Andi