Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: dts: ti: k3-am642-main: fix ports mac properties
To:     Grygorii Strashko <grygorii.strashko@ti.com>,
        Nishanth Menon <nm@ti.com>, Lokesh Vutla <lokeshvutla@ti.com>,
        Tero Kristo <kristo@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <20210608184940.25934-1-grygorii.strashko@ti.com>
From:   Vignesh Raghavendra <vigneshr@ti.com>
Message-ID: <abe15d92-83a7-d60f-c4b4-81e8b9ac415a@ti.com>
Date:   Wed, 9 Jun 2021 10:42:44 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210608184940.25934-1-grygorii.strashko@ti.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/9/21 12:19 AM, Grygorii Strashko wrote:
> The current device tree CPSW3g node adds non-zero "mac-address" property to
> the ports, which prevents random MAC address assignment to network devices
> if bootloader failed to update DT. This may cause more then one host to
> have the same MAC in the network.
> 
>  mac-address = [00 00 de ad be ef];
>  mac-address = [00 01 de ad be ef];
> 
> In addition, there is one MAC address available in eFuse registers which
> can be used for default port 1.
> 
> Hence, fix ports MAC properties by:
> - resetting "mac-address" property to 0
> - adding ti,syscon-efuse = <&main_conf 0x200> to Port 1
> 
> Fixes: 3753b12877b6 ("arm64: dts: ti: k3-am64-main: Add CPSW DT node")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---

Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>

>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index effb9d2e3c25..7f7178a7a055 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -514,7 +514,8 @@
>  				ti,mac-only;
>  				label = "port1";
>  				phys = <&phy_gmii_sel 1>;
> -				mac-address = [00 00 de ad be ef];
> +				mac-address = [00 00 00 00 00 00];
> +				ti,syscon-efuse = <&main_conf 0x200>;
>  			};
>  
>  			cpsw_port2: port@2 {
> @@ -522,7 +523,7 @@
>  				ti,mac-only;
>  				label = "port2";
>  				phys = <&phy_gmii_sel 2>;
> -				mac-address = [00 01 de ad be ef];
> +				mac-address = [00 00 00 00 00 00];
>  			};
>  		};
>  
>