Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5145966pxj; Wed, 9 Jun 2021 10:09:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOYxmNTYZhCLK4u/paBTYPRewLFBYXA6vXT2rcVfQUh4SRDPW0adU8RzXoJlwVLxMIMD8F X-Received: by 2002:a05:6402:b11:: with SMTP id bm17mr437557edb.109.1623258548634; Wed, 09 Jun 2021 10:09:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623258548; cv=none; d=google.com; s=arc-20160816; b=dOwoneMq1WCFpVmNKLhpi6Dff+A6yDe52i+cLQXt73jYru2gkATV61CrKT9zNBtf3k 6AmezywcLidJ0l2JT3phxOBsMMgshqdYFyKD69wpXObs6jlzUHFn/5CAM+FcEqP2002h TWtl8gXrbhiTmekfyLHYWZi6no2N8saLCkyCPjY4zJy1+08Mkmp03Z5WkoT9T1lraJme z4vvx11CQ5J3zX/aeToztuPusnlG+okBTe54xbKJ2emfEduxFmnGKgipyIUcxhKJaSGO QHQq+vnRUyXWG84K7wKfeRpjDYvE97zKTBYAZF5MeiwRJvZIvpTkozdEIOQsggixBeQ0 RKzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=XZgXu1dBrq0vDotpxIm4R3Mu2z8RAmcs296p/2z5HMY=; b=yUDsfkx6d1gF3tl+Imh6S/RqylT6P66fSB8U449HwhlWlcBXkAfB2gduljVYjawQad 5hKo1wY2a8TtR/242zFgZFLlqklHbI4+OHlQHj+oLbdz5WtQ4110scGrksrvs2nsiQLn bEPE+jlBNJpJ45zXr6zFZ6KTfqSH5ROjV2hR4OGM8RQbATAh/m2zzorMQ3ovJb/Fgq2m aCRUYQc9RKKoYvt5makFBlmm30pdYglYFtOjWQNxsTl3XYTkk53QC1FC6ace1cmxwfvP ZTIXcGGEkFFFkrl4M3U/y/SBMErJhPUotzCTRKO1ALZqZS3j9xBvO2MmWGWJFN+gJ/dx USog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jo17si306361ejb.32.2021.06.09.10.08.43; Wed, 09 Jun 2021 10:09:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236424AbhFIHAm (ORCPT + 99 others); Wed, 9 Jun 2021 03:00:42 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3915 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235329AbhFIHAl (ORCPT ); Wed, 9 Jun 2021 03:00:41 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G0Htk2KH1z6vtc; Wed, 9 Jun 2021 14:55:42 +0800 (CST) Received: from dggpeml500020.china.huawei.com (7.185.36.88) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 9 Jun 2021 14:58:46 +0800 Received: from huawei.com (10.175.127.227) by dggpeml500020.china.huawei.com (7.185.36.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 9 Jun 2021 14:58:45 +0800 From: Baokun Li To: , Christian Koenig , Huang Rui , David Airlie , Daniel Vetter , Sumit Semwal CC: , , , , , , , , , "Hulk Robot" Subject: [PATCH -next v2] drm/ttm: use list_move instead of list_del/list_add in ttm_execbuf_util.c Date: Wed, 9 Jun 2021 15:07:50 +0800 Message-ID: <20210609070750.1329318-1-libaokun1@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500020.china.huawei.com (7.185.36.88) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using list_move() instead of list_del() + list_add() in ttm_execbuf_util.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li --- V1->V2: CC mailist drivers/gpu/drm/ttm/ttm_execbuf_util.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_execbuf_util.c b/drivers/gpu/drm/ttm/ttm_execbuf_util.c index 071c48d672c6..c50943888d04 100644 --- a/drivers/gpu/drm/ttm/ttm_execbuf_util.c +++ b/drivers/gpu/drm/ttm/ttm_execbuf_util.c @@ -95,8 +95,7 @@ int ttm_eu_reserve_buffers(struct ww_acquire_ctx *ticket, if (ret == -EALREADY && dups) { struct ttm_validate_buffer *safe = entry; entry = list_prev_entry(entry, head); - list_del(&safe->head); - list_add(&safe->head, dups); + list_move(&safe->head, dups); continue; } @@ -135,8 +134,7 @@ int ttm_eu_reserve_buffers(struct ww_acquire_ctx *ticket, /* move this item to the front of the list, * forces correct iteration of the loop without keeping track */ - list_del(&entry->head); - list_add(&entry->head, list); + list_move(&entry->head, list); } return 0;