Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5146920pxj; Wed, 9 Jun 2021 10:10:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGSJTcHbjmAk7HRkRHy/1DvlIYUTZvyPsWZgwQ/YAm9cN84ed2pBAU0Rm+eEldmIgt8t7V X-Received: by 2002:a05:6402:1511:: with SMTP id f17mr428120edw.377.1623258625753; Wed, 09 Jun 2021 10:10:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623258625; cv=none; d=google.com; s=arc-20160816; b=tWjhejKXbJbmf7WAcN7+6mhvDjBKYDymp6G9v+nnxv3iquH9njNyBwm35VkGv0Xz5G nzuJm3GLhOtDavrKVR7fS28+v+BkwGI3fxJcTIOU1BURH7YlPWlcASSy+6n2v3b6YskQ qrlM02aWClkdpN8BBrwRpi+8FfeLmufd+9kjD1NyCm1ukz9tPfsNu23/05WEafc9OTQy ZA1pEg/qWg3ZUojnXysom7e5w3tjlbY4AcKY0e7CByux0AEqxvDcmTds6eWNJE8I6xZa 2Z+/X73iP67TbwIy4/AQhOzfTY3uGwrC9mXaZdVtHNYrSu3xAcDqE3uxcQt5cq8T+doI cIqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=1TUXT7ckqwdbUZT+KNJy9096X3SVhELdoKFOf+rr2x0=; b=MEr13369ix5s8E4rWpoz1PiOHICHYQjExfcAdT6YiAFszEaZ6dZqq3q8qct+nH2+Bg /I/6GtU8XyL5W0vKqNZdspCsiVS4SrIhvuz3CA7QAeNYFCE8073EGITi3iKchALxDlWz d/8j2HFmjS4KweW/hcDEltzTmIgKYA389fAHeneYKFPuQhIL4sfMmo0l2IlhgFKnaWOI ndYSLz2qghgtXletF+g90w7/+lsNa+Uf/r8iwineyvz9pv5eSPzzdRDWAojUO6AYGorV UWUpyPILR8S4JpYLZf+6wHamSsYkw8QT3Cz/mYI/7+LPm5CCY4PKf/LuowcgNPEHaL/0 V17Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d17si150037edv.586.2021.06.09.10.10.01; Wed, 09 Jun 2021 10:10:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237088AbhFIHRi (ORCPT + 99 others); Wed, 9 Jun 2021 03:17:38 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:3810 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232746AbhFIHRh (ORCPT ); Wed, 9 Jun 2021 03:17:37 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G0JDB2YCdzWtLx; Wed, 9 Jun 2021 15:10:50 +0800 (CST) Received: from dggpeml500020.china.huawei.com (7.185.36.88) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 9 Jun 2021 15:15:40 +0800 Received: from huawei.com (10.175.127.227) by dggpeml500020.china.huawei.com (7.185.36.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 9 Jun 2021 15:15:39 +0800 From: Baokun Li To: , Maximilian Luz , Hans de Goede , Mark Gross CC: , , , , , , , Hulk Robot Subject: [PATCH -next v2] platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_packet_layer.c Date: Wed, 9 Jun 2021 15:24:48 +0800 Message-ID: <20210609072448.1357524-1-libaokun1@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500020.china.huawei.com (7.185.36.88) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using list_move_tail() instead of list_del() + list_add_tail() in ssh_packet_layer.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li --- V1->V2: CC mailist .../surface/aggregator/ssh_packet_layer.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/platform/surface/aggregator/ssh_packet_layer.c b/drivers/platform/surface/aggregator/ssh_packet_layer.c index 15d96eac6811..2f546ad11c4e 100644 --- a/drivers/platform/surface/aggregator/ssh_packet_layer.c +++ b/drivers/platform/surface/aggregator/ssh_packet_layer.c @@ -1567,9 +1567,7 @@ static void ssh_ptl_timeout_reap(struct work_struct *work) clear_bit(SSH_PACKET_SF_PENDING_BIT, &p->state); atomic_dec(&ptl->pending.count); - list_del(&p->pending_node); - - list_add_tail(&p->pending_node, &claimed); + list_move_tail(&p->pending_node, &claimed); } spin_unlock(&ptl->pending.lock); @@ -1957,8 +1955,7 @@ void ssh_ptl_shutdown(struct ssh_ptl *ptl) smp_mb__before_atomic(); clear_bit(SSH_PACKET_SF_QUEUED_BIT, &p->state); - list_del(&p->queue_node); - list_add_tail(&p->queue_node, &complete_q); + list_move_tail(&p->queue_node, &complete_q); } spin_unlock(&ptl->queue.lock); @@ -1970,8 +1967,7 @@ void ssh_ptl_shutdown(struct ssh_ptl *ptl) smp_mb__before_atomic(); clear_bit(SSH_PACKET_SF_PENDING_BIT, &p->state); - list_del(&p->pending_node); - list_add_tail(&p->pending_node, &complete_q); + list_move_tail(&p->pending_node, &complete_q); } atomic_set(&ptl->pending.count, 0); spin_unlock(&ptl->pending.lock);