Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5148010pxj; Wed, 9 Jun 2021 10:11:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7M80yS5Znrkk2ezxjPt7YjILBKLJMpcIMT5wsiWe0RHflvP5eA1CLFCHgDXJwXWWOgYx8 X-Received: by 2002:a17:907:206a:: with SMTP id qp10mr829755ejb.309.1623258714651; Wed, 09 Jun 2021 10:11:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623258714; cv=none; d=google.com; s=arc-20160816; b=gESbXOS5jx+qqBmCMurRWhHfwVgKPJ4LoZT73PJzWAJCOZqI9JiV0IoG43gHKDMuKM EF4HePWILcL9z9DVeNVrHMeSjVTmX2t10qT187oNHpPgauXrQ2qWPXlDHq2aamqgB+qe VxncL0JUE7kVTRY6jApwRwZbvTVC6gFQB5hMn2SqQ+IaDG0XQ2hWZr5I+/FD1Ym01QX+ Fn/BpwGjcu5dBsiKpYMa/hItkBAP2wpBmXIRkbuj7vFKF3BJvyrjW6M5lC8K1pmzxbl+ +cmWBA6sa9L88i4dpoNXVbUqAXx9Ft3Fqy6Kt1T3Mi7Htm46ySXS7Vl7v4xXlZw/ZU/N ATjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=u95JwBId0M18cD1xDdxK6cHSDljyVKHYVaZtVlOmUok=; b=YipVsR0UE5Nm2OL8ua+xvlftoRbLoKwiXnYm002BiocZc7DYvHuBr6tFmtbIilKUtv cP/nrV2mTOTMYUsSYIgd1CKeseTJVbA7QtjHGPWMtx6z/3CZwImkIovRyLMbzYYPeFmL t9PFavXmiN/reoIqS5poiz3Jllotu6fMOLS1JB352wlwrfIhBBuWuPZ07ug++4LbI2dl wfNy1WWCEBz6hVwxiU1wyvsV2Ak3vSgJ25h4ceZw2H3KlKkZmZnW3cBLpKbH7dS5L4Fp jFZAUCDOSzMAIonGc6cCu07oN4xyZ9Qvny/e8hkAR8HOYGRfuppC6jmAFHhUSTVSwUFS cYKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hp35si325820ejc.369.2021.06.09.10.11.29; Wed, 09 Jun 2021 10:11:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237694AbhFIIEr (ORCPT + 99 others); Wed, 9 Jun 2021 04:04:47 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:55313 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237459AbhFIIDf (ORCPT ); Wed, 9 Jun 2021 04:03:35 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id B26EA20001A; Wed, 9 Jun 2021 08:01:38 +0000 (UTC) From: Miquel Raynal To: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , , Rob Herring , , Krzysztof Kozlowski Cc: Michal Simek , Naga Sureshkumar Relli , Amit Kumar Mahapatra , Thomas Petazzoni , , , helmut.grohne@intenta.de, Srinivas Goud , Siva Durga Prasad Paladugu , Miquel Raynal Subject: [PATCH v22 11/18] memory: pl353-smc: Rename goto labels Date: Wed, 9 Jun 2021 10:01:05 +0200 Message-Id: <20210609080112.1753221-12-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210609080112.1753221-1-miquel.raynal@bootlin.com> References: <20210609080112.1753221-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A goto label is better named do_something: than out_something_to_do: Use the former wording and really describe what the jump involves. Signed-off-by: Miquel Raynal --- drivers/memory/pl353-smc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/memory/pl353-smc.c b/drivers/memory/pl353-smc.c index 2d20b1b2c0e3..14720430bf9e 100644 --- a/drivers/memory/pl353-smc.c +++ b/drivers/memory/pl353-smc.c @@ -388,7 +388,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id) err = clk_prepare_enable(pl353_smc->memclk); if (err) { dev_err(&adev->dev, "Unable to enable memory clock.\n"); - goto out_clk_dis_aper; + goto disable_axi_clk; } amba_set_drvdata(adev, pl353_smc); @@ -408,7 +408,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id) } if (!match) { dev_err(&adev->dev, "no matching children\n"); - goto out_clk_disable; + goto disable_mem_clk; } init = match->data; @@ -418,9 +418,9 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id) return 0; -out_clk_disable: +disable_mem_clk: clk_disable_unprepare(pl353_smc->memclk); -out_clk_dis_aper: +disable_axi_clk: clk_disable_unprepare(pl353_smc->aclk); return err; -- 2.27.0