Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5149998pxj; Wed, 9 Jun 2021 10:14:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzl2VsKyslatKZIeVqdM3b/cif67cGnMoYRQyt6iVGZzbrUt/LpYaKiC///xlra/Fvm0VjO X-Received: by 2002:a17:906:c311:: with SMTP id s17mr877908ejz.202.1623258884797; Wed, 09 Jun 2021 10:14:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623258884; cv=none; d=google.com; s=arc-20160816; b=YOBII2VqkdQDOZvuoMIuAvK/Z0BTIdIz5kdyjWQXF72c+k9oAKdLpeGm5qJPhPCEE4 aOdZplcjc43IO0JZdQW0n7CtaJ7wEvq+69OIdor0AuFRuZV8UIGlXxxCAxdZNpVeGquJ dY/emu5zdv3lXPOwtXkD04GgZHx/p/KWAdw++NrSdRodP2Ml2l9yJ6XCDTbkXXRn12uF h7LAR2n0iTg6+dy4zKeS3L9+BLt3f9DmsVzKgnb/tgoxfobncai7aX+5gQ0FYEb/AgK7 WnRnwPn1xmTrd1LBJnS4jcma3j+9iESZ3L4D/m6My3K61j2gTkvl5RC3d7WTiIsLCNij BlUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=2y5KvAK0/V1WL2Ml9E+60vvrQOHkhvKazOsX4BLOSAw=; b=HqSTd0ZgUksEGeCsgl8oLnuPG5eBUp2tOvW8i41uP7/3JNbkSU4XDODuqZK8R/71ao zQgEOOBrwidW/zv1N4avsyNA/taAjEYGIJBkZnSIZ35ohq7ZCr4KgSxw8JTNArWvmQQf 2P9g7cPfInsZmmDrDuaDxUMVswzHyLIoSYFZ7A6LzOU5R6mlluMK4jXTiecj0c862yHe kMlxT5MhupJt1s8n6sq/NAwFfm5V/mlubVKFpqWQ7or/nwlO8ng2SdnlNluvSEdtxbnt 0YFb7f+oqwJvl+L5wgS98Dhx4LG76UxBkhmx99hMN8TJ0wlxx7YT8gewSqM54zMczwvS evkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kl25si290034ejc.370.2021.06.09.10.14.20; Wed, 09 Jun 2021 10:14:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238234AbhFIJpS (ORCPT + 99 others); Wed, 9 Jun 2021 05:45:18 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:5305 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238216AbhFIJpQ (ORCPT ); Wed, 9 Jun 2021 05:45:16 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4G0MVD4yCxz1BK2c; Wed, 9 Jun 2021 17:38:12 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 9 Jun 2021 17:43:04 +0800 Received: from localhost.localdomain (10.67.165.24) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 9 Jun 2021 17:43:04 +0800 From: Guangbin Huang To: , , , , CC: , , , Subject: [PATCH net-next 5/9] net: lapbether: remove unnecessary out of memory message Date: Wed, 9 Jun 2021 17:39:51 +0800 Message-ID: <1623231595-33851-6-git-send-email-huangguangbin2@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1623231595-33851-1-git-send-email-huangguangbin2@huawei.com> References: <1623231595-33851-1-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggemi759-chm.china.huawei.com (10.1.198.145) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peng Li This patch removes unnecessary out of memory message, to fix the following checkpatch.pl warning: "WARNING: Possible unnecessary 'out of memory' message" Signed-off-by: Peng Li Signed-off-by: Guangbin Huang --- drivers/net/wan/lapbether.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c index 169b323..705a898 100644 --- a/drivers/net/wan/lapbether.c +++ b/drivers/net/wan/lapbether.c @@ -266,10 +266,8 @@ static void lapbeth_connected(struct net_device *dev, int reason) unsigned char *ptr; struct sk_buff *skb = __dev_alloc_skb(1, GFP_ATOMIC | __GFP_NOMEMALLOC); - if (!skb) { - pr_err("out of memory\n"); + if (!skb) return; - } ptr = skb_put(skb, 1); *ptr = X25_IFACE_CONNECT; @@ -286,10 +284,8 @@ static void lapbeth_disconnected(struct net_device *dev, int reason) unsigned char *ptr; struct sk_buff *skb = __dev_alloc_skb(1, GFP_ATOMIC | __GFP_NOMEMALLOC); - if (!skb) { - pr_err("out of memory\n"); + if (!skb) return; - } ptr = skb_put(skb, 1); *ptr = X25_IFACE_DISCONNECT; -- 2.8.1