Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 9 Jun 2021 14:23:02 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Sander Vanheule <sander@svanheule.net>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Adrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 1/2] Revert "regmap: mdio: Add clause-45 support"
Message-ID: <20210609132302.GA9596@sirena.org.uk>
References: <cover.1623238313.git.sander@svanheule.net>
 <deed937f8fd63285e95acdfa8ca327638057811f.1623238313.git.sander@svanheule.net>
 <20210609122401.GA20286@sirena.org.uk>
 <ba7ef002d610ff5b5fc2c31411a1009587e2f068.camel@svanheule.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="FCuugMFkClbJLl1L"
Content-Disposition: inline
In-Reply-To: <ba7ef002d610ff5b5fc2c31411a1009587e2f068.camel@svanheule.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--FCuugMFkClbJLl1L
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 09, 2021 at 02:42:06PM +0200, Sander Vanheule wrote:
> On Wed, 2021-06-09 at 13:24 +0100, Mark Brown wrote:

> > Please submit patches using subject lines reflecting the style for the
> > subsystem, this makes it easier for people to identify relevant patches.
> > Look at what existing commits in the area you're changing are doing and
> > make sure your subject lines visually resemble what they're doing.
> > There's no need to resubmit to fix this alone.

> I had grepped the commit log for other reverting patches, which also appear to
> use this style, but I didn't check the regmap-specific ones.

There's nothing in submitting-patches.rst which says to skip the usual
process for reverts - the fact that people sometimes apply things with
non-ideal subject lines doesn't mean it's best practice.

> I'll submit a v2 that fixes __regmap_init_mdio, and also applies the address
> checks to C45 access.

OK.

--FCuugMFkClbJLl1L
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDAwLUACgkQJNaLcl1U
h9BSFQf+JeEFVyZ7fyAaVO2H/zrC6fiFqlCxCWYdv5dUWhYcTFtfUlP9eJ6I8jRz
3n5iv8LX65jDTceUDaTdB0pwUS83l9xqOGSKKGI+cMXGXVuNl6pkYJ7pK4o3GYsM
CoOFj9KB1KjLwtRBQ545BxkOHszNzH+GIfPyEmJdfxPuYzktm9/0E51txUjX7oX/
huMeFjGgyBQKDg2S/CjRtn74b0Thc6L5tHs/T2vxKv3VzXSAnCxfKS8bscWdXGMN
y+OlgI/NyJ0+WXriaajQjGNg7R04YeGVUpXotAd7D/g7XzVv4uju5CCefFqDFp3E
kf/oWZY2xVCm+edyE4T1ftUgA6Ajgg==
=kyPO
-----END PGP SIGNATURE-----

--FCuugMFkClbJLl1L--