Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <alpine.DEB.2.22.394.2106091033070.5695@hadrien>
In-Reply-To: <alpine.DEB.2.22.394.2106091033070.5695@hadrien>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Wed, 9 Jun 2021 22:54:54 +0900
Message-ID: <CAK7LNATFuRk7zeuPec4F2S2C_0y4FcgPhev8A9xixC9O38--DQ@mail.gmail.com>
Subject: Re: Makefile: make modules install output
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jun 9, 2021 at 7:16 PM Julia Lawall <julia.lawall@inria.fr> wrote:
>
> make modules install used to end up with something like
>
>   INSTALL sound/usb/usx2y/snd-usb-usx2y.ko
>   INSTALL sound/x86/snd-hdmi-lpe-audio.ko
>   INSTALL sound/xen/snd_xen_front.ko
>   INSTALL virt/lib/irqbypass.ko
>   DEPMOD  5.12.0-rc2myfix-00015-gc6f886546cb8
>
> From v5.13-rc1, it gives:
>
>   STRIP   /lib/modules/5.13.0-rc1myfix/kernel/fs/btrfs/btrfs.ko
>   STRIP   /lib/modules/5.13.0-rc1myfix/kernel/fs/xfs/xfs.ko
>   STRIP   /lib/modules/5.13.0-rc1myfix/kernel/net/mac80211/mac80211.ko
>   STRIP   /lib/modules/5.13.0-rc1myfix/kernel/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko
>   STRIP   /lib/modules/5.13.0-rc1myfix/kernel/drivers/gpu/drm/amd/amdgpu/amdgpu.ko
>   DEPMOD  /lib/modules/5.13.0-rc1myfix
>
> Is the full path name considered to be an improvement?

I think so.
It is clear where the files are being installed to.

Another motivation was rather to make it aligned with the convention.

Kbuild log convention is this form:

  [ACTION]   [DESTINATION]


For example, when Kbuild is building kernel/foo.c
into kernel/foo.o

  CC      kernel/foo.o

is shown.


In this case, Kbuild is installing kernel/fs/btrfs/btrfs.ko
to /lib/modules/5.13.0-rc1myfix/kernel/fs/btrfs/btrfs.ko

So, I think it is more consistent to show the destination
rather than the source.


> For the names of
> the modules, it doesn't much matter, but the DEPMOD line was a convenient
> way to get the full kernel name for subsequent rebooting.
>
> thanks,
> julia


-- 
Best Regards
Masahiro Yamada