Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5193561pxj; Wed, 9 Jun 2021 11:19:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZxjhg4zijPvMQkYapYbqS+d/wurD3RhR1AAcHlJB2jxpzmoAFUSkIOY10Ys1Uv8G45BFi X-Received: by 2002:a17:906:a203:: with SMTP id r3mr1077822ejy.361.1623262753205; Wed, 09 Jun 2021 11:19:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623262753; cv=none; d=google.com; s=arc-20160816; b=Pbd3vYbT+g1ZKdimGit1NRGoxWCkIMe2HvzAxyH7BJdwtgdlkJtQuMQzpHNCYw6tP5 8grvRAnZS9ab9sWLrx7A95AOEzNQjv0GpBiW+mpyz30nTVWvaSsipDq2XnWfi3ASAJxo uVgkTDIr4t//QvSJAATnuzDebUQ5WRMlQXfSHUhYMTwRsCdR/o1+wO7/yZZhgEjTUdYb uRFIzfVDpYSAanKm8yMYA+io2NTPSFXS9mkOiYoKCzzuCjtiZuoC+2m1NjwNZgWEE3HB ZbRO/gr/qMwjKLlmayx2WWNJqSeRQQW8KWMMF1phBT+nJ2OTUEM0GYdzT2bQkNKn+nSq WfAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OyS7nlxq1SYrw+WUKc0O0Z4A8OI01bK+rJe/uwjy9aU=; b=pQVRYz8JpDsVzwNJ+MBvf6IAQHDEp4suYK9fX4oG46NQMmQKU1mDr9616dP8Mjv73p j+Tsocv9Cfmz+I5m+OMQptE3kdJYauP+YnS2C0auQVPJ3t0VgoJKjyHMO1NOGGQkDgFe IOQH6Tst7vfjDW6gRyHCo7uwUjV/c4+W2C5dTy6lQpTzAVqEbKxNm0jkiJsuE5pawKSi MlA78d8owbrLZTIz4JYV3QUT9u7uJlSKHErsSGDJ7YZnrdlRB3WAzfIL4IM6lhkDDSRe /Ks05OAr3q93cfXREGhKtRxbQV0NO60TnJDWaBeHsteofBsb1VAIfz0dHK07ZJYVvPWn nS/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=kOdPYrnJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q8si254029edd.329.2021.06.09.11.18.34; Wed, 09 Jun 2021 11:19:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=kOdPYrnJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231936AbhFISBP (ORCPT + 99 others); Wed, 9 Jun 2021 14:01:15 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:54499 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231745AbhFISBP (ORCPT ); Wed, 9 Jun 2021 14:01:15 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C8BA65C0081; Wed, 9 Jun 2021 13:59:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 09 Jun 2021 13:59:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=OyS7nl xq1SYrw+WUKc0O0Z4A8OI01bK+rJe/uwjy9aU=; b=kOdPYrnJnJtiC+tiydMCSp HzwLN/J9FhhiCEYehQQ4qh9YySLYQrYZNTz99iF187MD1Y6eGuWkkx7HYoOEDiMn uT3596NupWYC47HZ8gez3ofVUnitMxMe+LH2yIaixuwCYyW7SdeNSxtWxHYWfNzZ IWSReWtD6FuwoThv5XI/Yyuo6ynNoJwFyYUlEmhC7Lzzx9JvEk0uaLZaR7SvYQjO bMY/ugpE1Jgwc77WxTMx21InlfXOCk6i2NkJTupGi+8VemmQPk47xchMCSBksTQM xnN8z224OSJrtSGgDHErn4gpeH2ZAC6Xm4W3rqVFaHZt+gDwFatinT4Em1RAtLwg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeduuddguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnheptdffkeekfeduffevgeeujeffjefhtefgueeugfevtdeiheduueeukefhudeh leetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Jun 2021 13:59:18 -0400 (EDT) Date: Wed, 9 Jun 2021 20:59:14 +0300 From: Ido Schimmel To: Oleksandr Mazur Cc: jiri@nvidia.com, davem@davemloft.net, kuba@kernel.org, Vadym Kochan , Taras Chornyi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, nikolay@nvidia.com, roopa@nvidia.com Subject: Re: [PATCH net-next 10/11] net: marvell: prestera: add storm control (rate limiter) implementation Message-ID: References: <20210609151602.29004-1-oleksandr.mazur@plvision.eu> <20210609151602.29004-11-oleksandr.mazur@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210609151602.29004-11-oleksandr.mazur@plvision.eu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 09, 2021 at 06:16:00PM +0300, Oleksandr Mazur wrote: > Storm control (BUM) provides a mechanism to limit rate of ingress > port traffic (matched by type). Devlink port parameter API is used: > driver registers a set of per-port parameters that can be accessed to both > get/set per-port per-type rate limit. > Add new FW command - RATE_LIMIT_MODE_SET. This should be properly modeled in the bridge driver and offloaded to capable drivers via switchdev. Modeling it as a driver-specific devlink parameter is wrong.