Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5233194pxj; Wed, 9 Jun 2021 12:20:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGODtfSBSPc/OgCDzo8Ilq2jQwPoq73A2Y1PsAEmGjFzzwvu6PS+a5aH4lRajvgrPDGodA X-Received: by 2002:a17:906:3b87:: with SMTP id u7mr1290209ejf.548.1623266449943; Wed, 09 Jun 2021 12:20:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623266449; cv=none; d=google.com; s=arc-20160816; b=lrnMYYrWSl7DwLBS9cGOfJ76IvQsS/Q4N3YVbZvWxo3FJnO5F/Rrm845QVdW9iDqYP 9DEV5rWnl1+6X+Y9yk7ZUyqNd987CuPZaqsh8geed40gYCtztw+3yg9md88FB0ZyN5nx kBl48z0NhZ8c+7f1zPe1JSoLB1IKFnRQz3zdGflRXdM6CZodIaN56qLawJsSE6RaN0A/ TWtDqlmvNlD91HGj7iZfHviOkA0yRpqRPaKuitiDb6exTOeT7aRqqb0NKw4mLSwVBWYD 5DUTb5e6X5zpJbnO13K3HcR3wDZDmKegojDPJP80wGeFEN2DgIzIQ0U/3NLoSK4XdfLy tOVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kgL+ZMw3Dnt1bwmNyaDVXkAb+qFmjUi+kcFdcWYjdCk=; b=U//V8JAjdrAPMzNZesF8qRAKrS43TIKJ6em41HeloJAKIW1jEkxNUb9h1qN75J3ldv hEbNe5At8DUo7idACBBOXN/KZyjcPHiAs4cGLt6ACbf0qi9EC/fYg7hJ4x7ko/4b/eV8 4HFNoHwYz5uMik7h5O+//3RCqAN2rVf0sVS9HpML3/wP0uaGMDa5KRTm2eGdwlYwMuqF BXxXUC9sXv0mb9JtQc16ZGHWg80vLSiE6wmzelpk596kjAz7AUomAI8vm3X/xMXma2dR PI/L1UAZqdlZYDz+v5tU0ZAz3G0nxUSbedbHkaCiiUiESWTHDgR7MXkZTOT/DpHhrM93 MiZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FA0IuT82; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b18si439267edv.227.2021.06.09.12.20.26; Wed, 09 Jun 2021 12:20:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FA0IuT82; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbhFITSR (ORCPT + 99 others); Wed, 9 Jun 2021 15:18:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:58638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbhFITSP (ORCPT ); Wed, 9 Jun 2021 15:18:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3E32F613D4; Wed, 9 Jun 2021 19:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623266165; bh=4cqLWh1ppp/hZrwvpFtKbyel9fKraZQyl4S5GrUmaVI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FA0IuT82Kmgb26c4HTEsXhhtvzA+EzUysDU8lXY0+Kh9VkRo5vsJ8K8o+83kTaSBK 83h9SUNVw+pEmcWmhu42J42Rq9Loxp1JkA/ihTPv3Wb/CrbSPv27GI+R3J2uRAX1U1 yRpYkVqhuHlOYypXxehed+CqsD/H0UoDc/OuZ3WY= Date: Wed, 9 Jun 2021 21:16:02 +0200 From: Greg KH To: Tom Rix Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, nava.manne@xilinx.com, dinguyen@kernel.org, krzysztof.kozlowski@canonical.com, yilun.xu@intel.com, arnd@arndb.de, fpacheco@redhat.com, richard.gong@intel.com, luca@lucaceresoli.net, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/4] fpga: reorganize to subdirs Message-ID: References: <20210609142208.3085451-1-trix@redhat.com> <2738ee7a-448f-c327-c430-13fb44da45ec@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 09, 2021 at 11:52:44AM -0700, Tom Rix wrote: > > My main complaints here are: > > - these patches were not tested > > - you renamed kernel modules "accidentally" > > - you forgot SPDX lines > > - lack of description of why these files being moved was > > necessary in the changelog where you moved the files > > > > Remember, patch 0/X never shows up in changelogs... > > I will respin and collapse the patches to a single patch with a better > commit log. They should not be a single patch, I never said that at all :( Please read what I wrote above, did I ever mention there was too many patches in the series here? {sigh} greg k-h