Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5297339pxj; Wed, 9 Jun 2021 14:05:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+4fcjUxys+P7ZH6REhkV8EpO0C1x33GdqY2nYzwpVXvd+rUUXSIob/J8jKFYJkgnlNMls X-Received: by 2002:a17:907:2156:: with SMTP id rk22mr1533375ejb.464.1623272712022; Wed, 09 Jun 2021 14:05:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623272712; cv=none; d=google.com; s=arc-20160816; b=fIFeGDCu9KkaKjUXf745bB6pvnNwb2ftIIw4E+Kcib5M3gbVbuvz2juUWxIsAIyeAk KtBsTxqw4aBITCHJEiQc1K8ot7gHQtnfKvaOVTGk7TwL1DEeZxnCQOiUowME2F70ibH5 cMdSX7JQSwL8jFUyIfSHcWe+S7i9EIoz2pyD2bGFrwcs+lql8MJBg55Q8NUq4kzEGL/y g/3xJNIBw5luSGsdyfhTL4HACC/+b39D1RKidOTtpKQ8Y5Y/8JMTYPO2z3beaLXkLohi 3LI9Ee9ETY4ih/edt+jVyn1ngoo4XDfxQXDHd4KW8AzUG/SkLg0Oi1AdbXVb8rWWMPON NKgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=xHUcd347ilL58WMxxrXfY5F/5g0PkXkPcQ1tXvgawYI=; b=JFuNAh8I3pTxcbtaYFNJjJ/oBDKt3e9nM2PT++AUPMp2XjhBtZs0sloozKSW5EY84n 5lWyTL/TfVrs4VogVGwUOl2FzJZrdCHG2XY5ibRcdz0jW+aEjAyQ4IqjBshB5y3AQwTa NRf1un4skG5FGBpmq4Xv1gfW1zT4qa8fju6wh3s/CmnudVA/9eKNhpisHItPbxPCIp5G AUorTS4VXHc1tNfuGb5SIRcTO5Aoj1UfHyl8m2Oy4ZIl7JANaKyJ5rRBkiRNeKIBo/69 uP05hSJDEulewQlMhT9TpfuX6Tup4THcFJaI0SUq7v27MtMDh6yb+2OSPXHb6uFTztVr n1SQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca23si598059edb.543.2021.06.09.14.04.45; Wed, 09 Jun 2021 14:05:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229715AbhFIVFR (ORCPT + 99 others); Wed, 9 Jun 2021 17:05:17 -0400 Received: from mga14.intel.com ([192.55.52.115]:44296 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbhFIVFO (ORCPT ); Wed, 9 Jun 2021 17:05:14 -0400 IronPort-SDR: AHkqv2dVpMCwmLx31KWyrtLAWc7sMDuqfrc6eyhw+TV6nuXZLbiT/z19uk5dWYgagb1h1vA1ED rlc+E6RKdCvg== X-IronPort-AV: E=McAfee;i="6200,9189,10010"; a="204981450" X-IronPort-AV: E=Sophos;i="5.83,261,1616482800"; d="scan'208";a="204981450" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 14:03:18 -0700 IronPort-SDR: JU1YjG4pfXFY5kHBBNI4hC8Ung5d2uGOP1HB7ea73X9oySnTHwIyFf9EinIyHMDwsL9mYoWJsF scQLbhZJ6lNA== X-IronPort-AV: E=Sophos;i="5.83,261,1616482800"; d="scan'208";a="482540018" Received: from dspaldin-mobl.amr.corp.intel.com (HELO [10.212.158.45]) ([10.212.158.45]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 14:03:18 -0700 Subject: Re: [RFC v2-fix-v5 1/1] x86: Skip WBINVD instruction for VM guest To: Kuppuswamy Sathyanarayanan , Peter Zijlstra , Andy Lutomirski , Tony Luck , Dan Williams Cc: Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Raj Ashok , Sean Christopherson , linux-kernel@vger.kernel.org References: <973add45-9fd2-7abc-3a97-96a26c263ea0@linux.intel.com> <20210609194926.1949859-1-sathyanarayanan.kuppuswamy@linux.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <7c06b567-9a65-8c7c-6046-3dcb32d4bb15@intel.com> Date: Wed, 9 Jun 2021 14:03:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210609194926.1949859-1-sathyanarayanan.kuppuswamy@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This changelog lacks both clear problem statements and a clear solution implemented within the patch. Here's a proposed changelog. It clearly spells out the two problems caused by WBINVD within a guest, and the proposed solution which fixes those two problems. Is this missing anything? -- VM guests that support ACPI use standard ACPI mechanisms to signal sleep state entry to the host. To ACPI, reboot is simply another sleep state. ACPI specifies that the platform preserve memory contents over (some) sleep states. It does not specify any requirements for data preservation in CPU caches. The ACPI specification mandates the use of WBINVD to flush the contents of the CPU caches to memory before entering specific sleep states, thus ensuring data in caches can survive sleep state transitions.e Unlike when entering sleep states bare metal, no actions within a guest can cause data in processor caches to be lost. That makes these WBINVD invocations harmless but superfluous within a guest. (<--- problem #1) In TDX guests, these WBINVD operations cause #VE exceptions. For debug, it would be ideal for the #VE handler to be able to WARN() when an unexpected WBINVD occurs. (<--- problem #2) Avoid WBINVD for all ACPI cache-flushing operations which occur while running under a hypervisor, which includes TDX guests. This both avoids TDX warnings and optimizes away superfluous WBINVD invocations. (<---- solution)