Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Raphael Norwitz <raphael.norwitz@nutanix.com>
To:     Shanker R Donthineni <sdonthineni@nvidia.com>
CC:     Raphael Norwitz <raphael.norwitz@nutanix.com>,
        Amey Narkhede <ameynarkhede03@gmail.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kw@linux.com" <kw@linux.com>, Sinan Kaya <okaya@kernel.org>,
        Len Brown <lenb@kernel.org>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v7 4/8] PCI/sysfs: Allow userspace to query and set device
 reset mechanism
Thread-Topic: [PATCH v7 4/8] PCI/sysfs: Allow userspace to query and set
 device reset mechanism
Thread-Index: AQHXXCoL0P5HbzLU706U/y8QJTrdCKsMPIcAgAAK6AD///dNAA==
Date:   Wed, 9 Jun 2021 22:48:30 +0000
Message-ID: <20210609220518.GA25895@raphael-debian-dev>
References: <20210608054857.18963-1-ameynarkhede03@gmail.com>
 <20210608054857.18963-5-ameynarkhede03@gmail.com>
 <20210609215724.GB25307@raphael-debian-dev>
 <712afcf7-5a46-8747-2fb1-ee167f406847@nvidia.com>
In-Reply-To: <712afcf7-5a46-8747-2fb1-ee167f406847@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hqz62FFpEK74klKv6BK7Hr1cAvebn7UwadVHj3lo/8hKmxn8/vnvdKxSSe+5?=
 =?us-ascii?Q?nztx6sqN5DyfpV8GuoLHf8FoOuPNvZ5dG6E2CIc9vmPTx/IirjGBsIsOJJuj?=
 =?us-ascii?Q?h7SKAoUr1aRizQzOunFODYqwHTrD6hriNdBkSsujOoOHL8mWLVI3Zo7MTbUi?=
 =?us-ascii?Q?dG2UR8+4g6r+6IY3fSY0ryIUWnGQP74qXkaYO/ZndN/XZ454qPjZoNjpx/vd?=
 =?us-ascii?Q?hn9YdLke6HILYpNsgLf1/tBX55+BkUbZpd4xbbIVDX445T+djlqmwKTeLqkT?=
 =?us-ascii?Q?LSf3MJpOYDFMluSogx9+/dhqpvqQTte78LJcfuenBsdpJ3h/hhkzswIlNJRP?=
 =?us-ascii?Q?8qBdS6JYyRlaE3H5kzxyuofS5Li4hDHDAibYYDpCdwB1fnd+ogF9VtohDheL?=
 =?us-ascii?Q?GN5I6DTNFAKmcpucqrL8YrBOQz6XiUScETOI5RkI0Mk6Ss28Tej9ciJnZPTI?=
 =?us-ascii?Q?13tRokk0ngRaWPiGqvdzFDHBIpQ9M+NOl1edNElx4JY3N3Yo6kjlaV9982w/?=
 =?us-ascii?Q?j9WdmcrkeTAOrruGUF9+0zeSFadQJasGE6vSZKcviLAorBB4363kVGFJpvbL?=
 =?us-ascii?Q?LSlEUnfUeJCKGnTAvGridQap6mO5RuvmWPyM9UW988YJlzTmjaMs35gzE2NG?=
 =?us-ascii?Q?FhPBVqqe4Bn1uwzC7HmkeGhYlL/4zfQdrnH+JTA0NbQWZHWHB4rK/2ihY+V5?=
 =?us-ascii?Q?/4gzBczOU9WQ4/xjZnkQ5fnK/HHSPjiDBa+h0cRCfqAwwu5Zmayk96Pu6kyF?=
 =?us-ascii?Q?zWofFGDthBTpApUgxNAHb+jkDePdmnuERAcQIEi5Hn1ewEibJZFpP7wkHclL?=
 =?us-ascii?Q?16vVpfvD2ZhWGWTuarN/yTl+j44x6ngwTuLik5sUzEZBIgf3PUjwGYUG8vwU?=
 =?us-ascii?Q?yi+Z32Gv3Bb2Wubcxe7vazQeE1PdEo6t71uPAxOJaA0XvaO0wHm09Dj8C6dn?=
 =?us-ascii?Q?slM4wL22e+kPNcrlPyIDdzaKyX6XI/sJte6fIFe7+kik2Fm/jOwGhfuwEM5d?=
 =?us-ascii?Q?VMfn0eqL2zouuP1Vfx64P2OmWzAFdcEWi9pOpULUEZUZVILRnZzVggiZG8vb?=
 =?us-ascii?Q?zTN99lTvJRNDUb59XbWxrdHkIKvxwdTFIn4jyv7fniF/CAd0FBfXhmgeZgOt?=
 =?us-ascii?Q?czud6npuMeusDun79vfLP157cCf2xv7HFTNyyH1pVF3W0dVhQFLNgFoxIXfq?=
 =?us-ascii?Q?aHVrRuFYkTxANQPhHI3JdRQJ762HOUZKl64+fq4j2z63ehNan6wvBLKgyMye?=
 =?us-ascii?Q?rUUghX63LoD44GGVUHMyrXBqMGkSadquXQ9d67MD1yv/X1/O/Vma/xocS3cz?=
 =?us-ascii?Q?rxipDqPBYH/cefju2HbSlmEDDm780jBy6oNuCw9ZSTfvuQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <14973C395F3CED42987D06295CBC0F30@namprd02.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nutanix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4543.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7d8d69b-6fdb-40ae-a883-08d92b98b3e6
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2021 22:48:30.1328
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bb047546-786f-4de1-bd75-24e5b6f79043
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KLpUrzxnpIQpjIQJw1B4FU0qek5pEroaTdqkL3fkf8ki6w7p9FblgHDlsIzjLeiu0J9mas4mRhKIYQeEpiXxGbsienk575f/ASICyfotnY4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR02MB7851
X-Proofpoint-GUID: DWD5F5mEu7S6-tZVsVYaBpjulH6wA_nD
X-Proofpoint-ORIG-GUID: DWD5F5mEu7S6-tZVsVYaBpjulH6wA_nD
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-06-09_07:2021-06-04,2021-06-09 signatures=0
X-Proofpoint-Spam-Reason: safe
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Yes - I got this one wrong.

Nevermind, looks good. Just the punctuation NIT.

On Wed, Jun 09, 2021 at 05:36:26PM -0500, Shanker R Donthineni wrote:
> Hi Raphael,
>=20
> On 6/9/21 4:57 PM, Raphael Norwitz wrote:
> >> +static ssize_t reset_method_show(struct device *dev,
> >> +                              struct device_attribute *attr,
> >> +                              char *buf)
> >> +{
> >> +     struct pci_dev *pdev =3D to_pci_dev(dev);
> >> +     ssize_t len =3D 0;
> >> +     int i, prio;
> >> +
> >> +     for (prio =3D PCI_RESET_METHODS_NUM; prio; prio--) {
> >> +             for (i =3D 0; i < PCI_RESET_METHODS_NUM; i++) {
> >> +                     if (prio =3D=3D pdev->reset_methods[i]) {
> >> +                             len +=3D sysfs_emit_at(buf, len, "%s%s",
> >> +                                                  len ? "," : "",
> >> +                                                  pci_reset_fn_method=
s[i].name);
> >> +                             break;
> >> +                     }
> >> +             }
> >> +
> >> +             if (i =3D=3D PCI_RESET_METHODS_NUM)
> >> +                     break;
> >> +     }
> >> +
> > Don't you still need to ensure you add the newline even if there are no
> > reset methods set? If the len is zero why don't we need the newline?
> >
> > Otherwise looks good.
> >
>=20
> sysfs entry 'reset_method' will not be visible if there are no reset meth=
ods.
>=20
> =