Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp73739pxj; Wed, 9 Jun 2021 16:58:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5q3UNsfgSAkDveS6zCr+QqDTb+eu+5LWIFHyEudIfK25ADpWOSMwbNg8ACCbGJDNTMDhB X-Received: by 2002:a17:906:2892:: with SMTP id o18mr1960344ejd.124.1623283094013; Wed, 09 Jun 2021 16:58:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623283094; cv=none; d=google.com; s=arc-20160816; b=pgHGXejQea0NofSBOQ2IFoaV5E3AdnTEKGHtszN+pzHNYcTY6qLEnUAHiDCsqBQUpb CpzMHEqVJTYseEIhvaohfxFEII0Z1RqZf0l7VzyEBC6Psy0eva/L61DYlVmGeD2dISkY 0jBY76Y2r7FItFi60A5UG8iY2fzIMwFRGyaqtMhtBGcn4sgrTa1taoJiT+R7WtJTW2pE aZtU0UTm5Pzh8Xhm9yEBKkeh24tWcN6uwYM47ci7VyoS4WxJH6B4bIp1W+fGJGN05mu9 6POKj7SdruuZ4DUJY7xgSttrsS2syP6xCVMmGb/9MWm7r51hrHvH0IA/W4PwBbmrBAkG +lWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=N+btBxTbxw4EKcHNU9tJo9p70e7W7XNjoq2uB6z+Bug=; b=upx6MpJQ/zziI7GWnFHcCPtnZFJxhqtpuLlohJ/pTCzBGH+IvwI2UIMTRmQQo9Dli0 udxe4vUyTsiGIpCSYnoN4C4TWsQcKbeDNF16MiRpSDIPTw7ZEWk8Qhv08TOFfroCIKtu e1/kzsHsiwEMpNCqN55/YIB/hX8jDuKiR2isvGIvd5psS4eZfC6/WjcFMZZLjTGKp7Hi /5rCuNzZsYcrVJg4NHSY9rPKgMb4hnJzujeJp0k+D12Es5ho/1yuTZv3ld+GP3UctfT/ fGr+vVj++oO1+gaH+FeKo72v0LDxC6JBqQYSgwonln+2BCrmiag+wAM0dJAS/DyawlI3 lTLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ha1si872682ejb.743.2021.06.09.16.57.50; Wed, 09 Jun 2021 16:58:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbhFIX5w (ORCPT + 99 others); Wed, 9 Jun 2021 19:57:52 -0400 Received: from mga14.intel.com ([192.55.52.115]:56072 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbhFIX5v (ORCPT ); Wed, 9 Jun 2021 19:57:51 -0400 IronPort-SDR: HKfR415D+KUWlt1KJ1R57gTwZjrHbHVmZ8R8KbCbWm9HZ7sr4GKeqdAuvbW+xbBnMwTxjh39yy Qk5RBjUsZR5w== X-IronPort-AV: E=McAfee;i="6200,9189,10010"; a="205008169" X-IronPort-AV: E=Sophos;i="5.83,262,1616482800"; d="scan'208";a="205008169" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 16:55:56 -0700 IronPort-SDR: JfAqpoIF5W03HnE3VjhOzj3tnrKC0kP0bXfU4buYWuoDX6a7HPat1hu+Ilgi6vYgrYADwW7/UY ceePn2A5vO0w== X-IronPort-AV: E=Sophos;i="5.83,262,1616482800"; d="scan'208";a="482591226" Received: from dspaldin-mobl.amr.corp.intel.com (HELO [10.212.158.45]) ([10.212.158.45]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 16:55:42 -0700 Subject: Re: [RFC v2-fix-v5 1/1] x86: Skip WBINVD instruction for VM guest To: "Kuppuswamy, Sathyanarayanan" , Dan Williams Cc: Peter Zijlstra , Andy Lutomirski , Tony Luck , Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Raj Ashok , Sean Christopherson , Linux Kernel Mailing List References: <973add45-9fd2-7abc-3a97-96a26c263ea0@linux.intel.com> <20210609194926.1949859-1-sathyanarayanan.kuppuswamy@linux.intel.com> <7c06b567-9a65-8c7c-6046-3dcb32d4bb15@intel.com> <2184400d-856e-ed4c-b23d-77b7dfd72658@linux.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <65ca2294-d36a-1a65-3bed-90f4fd7dd14a@intel.com> Date: Wed, 9 Jun 2021 16:55:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2184400d-856e-ed4c-b23d-77b7dfd72658@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/21 2:42 PM, Kuppuswamy, Sathyanarayanan wrote: > On 6/9/21 2:38 PM, Dan Williams wrote: >>> In TDX guests, these WBINVD operations cause #VE exceptions.  For debug, >>> it would be ideal for the #VE handler to be able to WARN() when an >>> unexpected WBINVD occurs. (<--- problem #2) >> ...but it doesn't WARN() it triggers unhandled #VE, unless I missed >> another patch that precedes this that turns it into a WARN()? If a >> code path expects WBINVD for correct operation and the guest can't >> execute that sounds fatal, not a WARN to me. > > Yes. It is not WARN. It is a fatal unhandled exception. That makes the problem statement a wee bit different, but it should still be pretty easy to explain: In TDX guests, these WBINVD operations cause #VE exceptions. While some #VE exceptions can be handled, there is no recourse for a TDX guest to handle a WBINVD and it will panic(). (<--- problem #2)