Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210430195232.30491-1-michel@lespinasse.org> <20210430195232.30491-5-michel@lespinasse.org>
In-Reply-To: <20210430195232.30491-5-michel@lespinasse.org>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Wed, 9 Jun 2021 17:38:28 -0700
Message-ID: <CAJuCfpFJfry1Td8Sbv27pqxE2CdSyH=6Cy065vL69JNQex1kOw@mail.gmail.com>
Subject: Re: [PATCH 04/29] do_anonymous_page: use update_mmu_tlb()
To:     Michel Lespinasse <michel@lespinasse.org>
Cc:     Linux-MM <linux-mm@kvack.org>,
        Linux-Kernel <linux-kernel@vger.kernel.org>,
        Laurent Dufour <ldufour@linux.ibm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Michal Hocko <mhocko@suse.com>,
        Matthew Wilcox <willy@infradead.org>,
        Rik van Riel <riel@surriel.com>,
        Paul McKenney <paulmck@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Joel Fernandes <joelaf@google.com>,
        Andy Lutomirski <luto@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Apr 30, 2021 at 12:52 PM Michel Lespinasse
<michel@lespinasse.org> wrote:
>
> update_mmu_tlb() can be used instead of update_mmu_cache() when the
> page fault handler detects that it lost the race to another page fault.
>
> (TODO double check with Bibo Mao <maobibo@loongson.cn>)

You probably can drop this TODO. It looks like this one call was
missed in https://patchwork.kernel.org/project/linux-mips/patch/1590375160-6997-2-git-send-email-maobibo@loongson.cn
after Andrew asked to replace all update_mmu_cache() calls with an
alias in the previous version of this patch here:
https://patchwork.kernel.org/project/linux-mips/patch/1590031837-9582-2-git-send-email-maobibo@loongson.cn/#23374625.

>
> Signed-off-by: Michel Lespinasse <michel@lespinasse.org>
> ---
>  mm/memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index 550405fc3b5e..59ff65cb3ab4 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3567,7 +3567,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf)
>         vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address,
>                         &vmf->ptl);
>         if (!pte_none(*vmf->pte)) {
> -               update_mmu_cache(vma, vmf->address, vmf->pte);
> +               update_mmu_tlb(vma, vmf->address, vmf->pte);
>                 goto release;
>         }
>
> --
> 2.20.1
>