Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp219051pxj; Wed, 9 Jun 2021 21:57:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkeSMESuaBZdJ50pmOUsc4HOEdI65OfxbOlVXmUJSq7tjPhUIH7411BKbUfTja+cExRI/u X-Received: by 2002:aa7:dd1a:: with SMTP id i26mr2831549edv.358.1623301053117; Wed, 09 Jun 2021 21:57:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623301053; cv=none; d=google.com; s=arc-20160816; b=j9japuWv/6tddnTbmu2SX13sux06J/Zg0zgC2nLn9JjhTlXzDeArN+sgnDwaYCxaTk 5x+Tt9wJ5hK4In60acJgKyAAuQvPQ4UvKvrsmkqCeLpcc0V/naLQ5n1gydVun+DZ1pen C1W8c8Q+9fGxl5FPKDQBE/th7EYOPNGE5VqGbVYevzr1L4vp5R2Xo/hL/5/GTvfZwRBW cnfrWfZKSCV+/+VI3/EAnhHOahL5JsguOpaEKHfyVr6i8eIR6Y4W8xukHkJn0seWDjYy 1TyApkJ6yD7outEBaafJxcxHWyJZa5GCHm4yW+B+e0TxyaOkPsqjvktvf02NFaLoCn+o naWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:to:from:subject:message-id; bh=M9Qz0ata1qBaEiVW7jnbA7MuEVAzq4+KK+TMqXODbnc=; b=wvb59mtlKFFnBogdN8oVJTYZPi05fGT1ttBgJKaOlkErih2RQRX7DuVvWqTZMZRJNL Ec9zh1safUsaBXhkDzGShwT9kVlQycHurMoL40h/aQTDjS0sTOV1Omvs9A8DYrnkHKOx hmJYsFj9yW8eF4h291eFR0Y4319at20/ZhO58Tesi+g+Svlb6YkpebcdwSk6MkiJCDEC UIgaHZjbSDkf4q2Qb53vFrWMVP3yr6lruxhj4uuAEqBOJ4OlFufJuX8FUiPm8tmCgEXS zswpdtm1AoN0/R51Y/ECVZy+xOxiONkYaBDqECrjyo83W8IDZZmDOi3d5Aml34mzpx/F k37g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ha1si1376137ejb.743.2021.06.09.21.57.07; Wed, 09 Jun 2021 21:57:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229715AbhFJE4r (ORCPT + 99 others); Thu, 10 Jun 2021 00:56:47 -0400 Received: from smtprelay0087.hostedemail.com ([216.40.44.87]:47808 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229529AbhFJE4q (ORCPT ); Thu, 10 Jun 2021 00:56:46 -0400 Received: from omf12.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 572B7181D337B; Thu, 10 Jun 2021 04:54:50 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA id 8007A24023F; Thu, 10 Jun 2021 04:54:47 +0000 (UTC) Message-ID: Subject: Re: [PATCH] scsi: ufs: Add indent for code alignment From: Joe Perches To: keosung.park@samsung.com, ALIM AKHTAR , "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "stanley.chu@mediatek.com" , "cang@codeaurora.org" , "beanhuo@micron.com" , "adrian.hunter@intel.com" , "asutoshd@codeaurora.org" , "satyat@google.com" , "bvanassche@acm.org" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Wed, 09 Jun 2021 21:54:46 -0700 In-Reply-To: <1891546521.01623299401994.JavaMail.epsvc@epcpadp3> References: <1891546521.01623299401994.JavaMail.epsvc@epcpadp3> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.10 X-Rspamd-Server: rspamout05 X-Rspamd-Queue-Id: 8007A24023F X-Stat-Signature: 1rrt63hpehtiueafoipnuh41kncp1i97 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18yOD5I0kpqbzHqufp09I0M3g46l2YLBuQ= X-HE-Tag: 1623300887-154885 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-06-10 at 13:07 +0900, Keoseong Park wrote: > Add indentation to return statement. [] > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h [] > @@ -903,7 +903,7 @@ static inline bool ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba) > ? else > ? return false; > ?#else > -return true; > + return true; > ?#endif > ?} > ? Perhaps a little refactoring instead: --- drivers/scsi/ufs/ufshcd.h | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index c98d540ac044d..ed89839476b3b 100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -894,15 +894,11 @@ static inline bool ufshcd_is_rpm_autosuspend_allowed(struct ufs_hba *hba) static inline bool ufshcd_is_intr_aggr_allowed(struct ufs_hba *hba) { /* DWC UFS Core has the Interrupt aggregation feature but is not detectable*/ -#ifndef CONFIG_SCSI_UFS_DWC - if ((hba->caps & UFSHCD_CAP_INTR_AGGR) && - !(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR)) + if (IS_ENABLED(CONFIG_SCSI_UFS_DWC)) return true; - else - return false; -#else -return true; -#endif + + return (hba->caps & UFSHCD_CAP_INTR_AGGR) && + !(hba->quirks & UFSHCD_QUIRK_BROKEN_INTR_AGGR); } static inline bool ufshcd_can_aggressive_pc(struct ufs_hba *hba)