Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Jun 2021 08:07:26 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Bart Van Assche <bvanassche@acm.org>
Cc:     daejun7.park@samsung.com,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Dukhyun Kwon <d_hyun.kwon@samsung.com>,
        Keoseong Park <keosung.park@samsung.com>,
        Jaemyung Lee <jaemyung.lee@samsung.com>,
        Jieon Seol <jieon.seol@samsung.com>
Subject: Re: [PATCH v36 4/4] scsi: ufs: Add HPB 2.0 support
Message-ID: <YMGsHp0eLObOkvKL@kroah.com>
References: <20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p2>
 <CGME20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p7>
 <20210607041927epcms2p707781de1678af1e1d0f4d88782125f7b@epcms2p7>
 <25912c0a-7f52-8b04-2ac1-6686aee01f87@acm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <25912c0a-7f52-8b04-2ac1-6686aee01f87@acm.org>
Precedence: bulk

On Wed, Jun 09, 2021 at 08:37:49PM -0700, Bart Van Assche wrote:
> On 6/6/21 9:19 PM, Daejun Park wrote:
> > -What:		/sys/class/scsi_device/*/device/hpb_sysfs/hit_cnt
> > +What:		/sys/class/scsi_device/*/device/hpb_stat_sysfs/hit_cnt
> >  Date:		June 2021
> >  Contact:	Daejun Park <daejun7.park@samsung.com>
> >  Description:	This entry shows the number of reads that changed to HPB read.
> >  
> >  		The file is read only.
> 
> Is it really useful to have a suffix "_sysfs" for a directory that
> occurs in sysfs? If not, please leave it out.

Ugh, missed that, yes it should be dropped, that's pointless :)

thanks,

greg k-h