Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp273612pxj; Wed, 9 Jun 2021 23:50:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1KaSA2l0hZ8V/2Bh40yVuih5EbGyo1AADCQUjMlWSxTKcpStvupngn4wF+3D7U5b8IyC9 X-Received: by 2002:a17:907:970f:: with SMTP id jg15mr3133387ejc.59.1623307850266; Wed, 09 Jun 2021 23:50:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623307850; cv=none; d=google.com; s=arc-20160816; b=0lFLJ9pPwJJiUQiGmziwVl2/2TRHL9KNkGtMiwAX1HNE1yp/us5/7KAG0yceOv/vOI osjF9NIqulOWokdlnum0rHpUTB4Olr2MPW6fIN1dJeCg1qcWDm31HneuKO+nD2fNqEzm DJpEeCJQdDgT8KcHpPPvlRylvM32vXUSNPTSaWWkkMm8qCDt55tD8O/amAYA1zriJMZW OUhH8Eq786wUryqRaMytgG+Bvr2+gvn5uAC/YtdEuCZVIxaRNgLHGSTzeSfQ1APb07ch 7Vph0k7iVXfKS16Sb4/lgCBzHRHMxO7BspbFUaN/78TXOs8ZRHb95OUuSzQ+9Gzbp07n AC0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=B1PYwuXcDI+5StA2526XZC20IXZ8SN/Lrl1SlQcegg4=; b=JNl7+KJFO16pmPg9jYEGh1G/00ceOcbqoO/iPfuI9Ne/BuLSPiALL5sc+i9WEeAOZj UE6hC0cYX6Fi4q9aOBWvEhIm8vn0v3wxWNB1PYyWPNtX5tIZ5U68+BIx0++1NlAUQEs/ HOkIXfIVCZAsC9K5eAz1JYNOyZIfNJGlso/oEcGQh+k7vf01xavAiahCogIqVtN4W+KE 78OnPkjbQkFH3XpMllBtRxjl8uvpt0W3MR1J0ZapRLmE2nveNhH4/qTkqqzptClUztJN /gp7ZAC7cMhf4xWFlSJobX/Fu/jpLVtdu4kFf/FMOxKAB+5kZljLSjTI/uyG7QBZk9Kt VZgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QB4gOl+E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m29si1557187ejl.33.2021.06.09.23.50.25; Wed, 09 Jun 2021 23:50:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QB4gOl+E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230042AbhFJGvK (ORCPT + 99 others); Thu, 10 Jun 2021 02:51:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:46162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229634AbhFJGvF (ORCPT ); Thu, 10 Jun 2021 02:51:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9A418613CA; Thu, 10 Jun 2021 06:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623307749; bh=iIkVGEdZ6nVOvPq75U9lbg5Ox4Vh5/72oUnE/OZA/bc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QB4gOl+EsIvP5QsweNEAYkLbiEjI3pWQwjomUchuL2PfwIp/zEtOjKbE9F2hlDdpX OmIKO0TbL/jsB/pJK6Oov3SCFutZZ4NqXnSRZ4dnaFVrFBJHMBdUCLS/zT+0IIMZND ULdlWuTbv+5ZUMshzIzBvnv4KIlFDhWAaQ+kfJRs= Date: Thu, 10 Jun 2021 08:49:06 +0200 From: 'Greg Kroah-Hartman' To: linyyuan@codeaurora.org Cc: 'Felipe Balbi' , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] usb: gadget: eem: fix command packet transfer issue Message-ID: References: <000201d75dbf$58d1cc40$0a7564c0$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000201d75dbf$58d1cc40$0a7564c0$@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 10, 2021 at 02:10:40PM +0800, linyyuan@codeaurora.org wrote: > From: Linyu Yuan > > there is following warning, > [] dwc3_gadget_ep_queue+0x1b4/0x1c8 > [] usb_ep_queue+0x3c/0x120 > [] eem_unwrap+0x180/0x330 > [] rx_complete+0x70/0x230 > [] usb_gadget_giveback_request+0x3c/0xe8 > [] dwc3_gadget_giveback+0xb4/0x190 > [] dwc3_endpoint_transfer_complete+0x32c/0x410 > [] dwc3_bh_work+0x654/0x12e8 > [] process_one_work+0x1d4/0x4a8 > [] worker_thread+0x50/0x4a8 > [] kthread+0xe8/0x100 > [] ret_from_fork+0x10/0x50 > request ffffffc0716bf200 belongs to 'ep0out' > > when gadget receive a eem command packet from host, it need to response, > but queue usb request to wrong endpoint. > fix it by queue usb request to eem IN endpoint and allow host read it. > > Cc: stable > Signed-off-by: Linyu Yuan > --- > drivers/usb/gadget/function/f_eem.c | 44 > ++++++++++++++++++++++++++++++++----- Your patch is line-wrapped and can not be applied :( Please fix your email client to properly send patches correctly. thanks, greg k-h