Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp274894pxj; Wed, 9 Jun 2021 23:53:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxjfAFAQCUYqDJ/jfLApk+U46wDacbjNvlCreFXPYRYv1kqnis/YLB/x3C7ktU/lWc5O7C X-Received: by 2002:a17:907:20dc:: with SMTP id qq28mr3135811ejb.440.1623308038310; Wed, 09 Jun 2021 23:53:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623308038; cv=none; d=google.com; s=arc-20160816; b=sYUbWUqisaLD2sm6TCzbN2tu//Q1/L0bPKy7qAK6jgTO8qKpJ0DeBgh/V7rhTTle5h vZC4L01xs41N7hux5JlWZEoNo9ITHlpxAY4yGs175YrCV0kxxFGPQy+v9tIhK3mCDMDy AewwEvqf9BYq71nKNrVT1dCZyYmOHC5qSWmhTq3/9tWfRzguNjeCxWqIZVO/Kz7s3vRc p7iMS1YhHi+ITXdcx4kVFqSARRH9BJ0dyzqQHo71Gx1pC0o9SuvbLNcpPlt4w63pKFLB ciizkelGLsaFM9NW2KwKDgXTuJDDlyDmdgu/s3zzypzmdCGXSj/GN9t1XMSVxgLePeFp lLDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=d+13d0IkQUPCOCnaebVB+S8Sj/ETJ+dNuzgT6hmH2zg=; b=ZIGA/0LC7g3fo8vZBPRSHn8DgDAhD6yz+dQhomicskMuzZrY5Blu5SHwpjMsEYSx36 2E6Oelf5LCU+mHZUHERn9j+Y3L2sbj8gwqsIS1sCemLv9YXe+NypCbQQLOuj6C/Rsedd F97yvewQRbuTQYD86lDWHBPUeRfsLp6Sqnl0D+hbJIOTz99HwsWRBbJuXpZDOrpFXD3x IBazD6/2j4FtU8Mzeu5nNSQXT8/6wPppreyL5O4JAvq24KGf7NzTskEjw86VKsQrORpn 3O+AC1CjVavWFGrUDhhdWTfMAKvKdb2EVkv6R4jpuT3nEh7If8LRESwVvCQ4w1Df8wjV ZQDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=v+A9wTWY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z7si1189919edx.603.2021.06.09.23.53.33; Wed, 09 Jun 2021 23:53:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=v+A9wTWY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230103AbhFJGxL (ORCPT + 99 others); Thu, 10 Jun 2021 02:53:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:47536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229634AbhFJGxL (ORCPT ); Thu, 10 Jun 2021 02:53:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C750C613E2; Thu, 10 Jun 2021 06:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623307859; bh=gL9kKCK+CsHPorwNub9yfvx7kZWcnzWe/A3bbR9fiEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v+A9wTWYBeEPqHsjLU+9uhEJGoaY2/nO4wsOyPnz9s/yEypfQInZrN7mWgLcfnkXE 9rO7xJnPs+CEgzOsrpcdogwRvxBIIOTa1UNZBhjL2wnEL351+hNcJJ4JgJ1IqJvDSz E4esok7hx70R0ZO86KlDLi++yBH/iYLVlnx/y0cI= Date: Thu, 10 Jun 2021 08:50:57 +0200 From: 'Greg Kroah-Hartman' To: linyyuan@codeaurora.org Cc: 'Felipe Balbi' , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] usb: gadget: eem: fix command packet transfer issue Message-ID: References: <000201d75dbf$58d1cc40$0a7564c0$@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000201d75dbf$58d1cc40$0a7564c0$@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 10, 2021 at 02:10:40PM +0800, linyyuan@codeaurora.org wrote: > From: Linyu Yuan > > there is following warning, > [] dwc3_gadget_ep_queue+0x1b4/0x1c8 > [] usb_ep_queue+0x3c/0x120 > [] eem_unwrap+0x180/0x330 > [] rx_complete+0x70/0x230 > [] usb_gadget_giveback_request+0x3c/0xe8 > [] dwc3_gadget_giveback+0xb4/0x190 > [] dwc3_endpoint_transfer_complete+0x32c/0x410 > [] dwc3_bh_work+0x654/0x12e8 > [] process_one_work+0x1d4/0x4a8 > [] worker_thread+0x50/0x4a8 > [] kthread+0xe8/0x100 > [] ret_from_fork+0x10/0x50 > request ffffffc0716bf200 belongs to 'ep0out' > > when gadget receive a eem command packet from host, it need to response, > but queue usb request to wrong endpoint. What is the full warning here? THe above traceback is a bit odd and does not show what is happening. > fix it by queue usb request to eem IN endpoint and allow host read it. I do not understand how this matches up with your kernel patch, when you resend this, can you please expand on this and make it more obvious what you are doing here? thanks, greg k-h