Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Jun 2021 07:45:29 +0000
From:   Quentin Perret <qperret@google.com>
To:     Xuewen Yan <xuewen.yan94@gmail.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Qais Yousef <qais.yousef@arm.com>, rickyiu@google.com,
        wvw@google.com, Patrick Bellasi <patrick.bellasi@matbug.net>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        kernel-team@android.com
Subject: Re: [PATCH] sched: Make uclamp changes depend on CAP_SYS_NICE
Message-ID: <YMHDGZM5d1DKm4lh@google.com>
References: <20210609175901.1423553-1-qperret@google.com>
 <CAB8ipk_LY=9G5E8TcE3b7i3Ntfj+vJUuqSR7LWYn8=yOaTtCEg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAB8ipk_LY=9G5E8TcE3b7i3Ntfj+vJUuqSR7LWYn8=yOaTtCEg@mail.gmail.com>
Precedence: bulk

On Thursday 10 Jun 2021 at 11:33:04 (+0800), Xuewen Yan wrote:
> On Thu, Jun 10, 2021 at 2:16 AM Quentin Perret <qperret@google.com> wrote:
> > +static bool uclamp_reduce(struct task_struct *p, const struct sched_attr *attr)
> > +{
> > +       int util_min, util_max;
> > +
> > +       if (attr->sched_flags & SCHED_FLAG_UTIL_CLAMP_MIN) {
> > +               util_min = p->uclamp_req[UCLAMP_MIN].value;
> > +               if (attr->sched_util_min > util_min)
> > +                       return false;
> > +       }
> > +
> > +       if (attr->sched_flags & SCHED_FLAG_UTIL_CLAMP_MAX) {
> > +               util_max = p->uclamp_req[UCLAMP_MAX].value;
> > +               if (attr->sched_util_max > util_max)
> > +                       return false;
> 
> when the attr->sched_util_max = -1, and the util_max < 1024, here may
> should return false, but it would return ture.

Aha, indeed, I missed that -1 could be used to reset the clamps. I'll
send a v2.

Thanks!
Quentin