Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp311340pxj; Thu, 10 Jun 2021 01:03:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwD4OFekf9gih0c9nvlDX2VAqo4/4Xfyo4yIKB0qU6I1kucTFjGM7fCBKS+IY6hrh8iQZRI X-Received: by 2002:aa7:cd9a:: with SMTP id x26mr3418761edv.185.1623312205594; Thu, 10 Jun 2021 01:03:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623312205; cv=none; d=google.com; s=arc-20160816; b=xs0YetYSfyK6+IU6wqfFz/qTWGGM+D1aU9NHY9qtNjptvVSx3Ndn1W8guMSekETZZO H4rM4JlQeFaYOJUpuImUdqYZLIt9/tFCXCYMvhyJCnemd/T+XbExwcTIaRj3fn9vzJJC X2LjHAApxXCrqk7vl0KXICNzkz52pehF+WXG97mecekEloslkxGdUzGfgB6WJRd6S8qb nRSjR2by9IZvaHoZqcKh3O3sRIMbIGn1PmlrLPDaqg+2O/uWDMe0QF/PEEj4aj+IkYWR rw0B5+HeOI6iu15q68hMNgswV1nzyDzn2R867vhZEC3jC10rA565AwuOudBx4dpOQFka FD1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Z8Q0hqWJSG4oD1OkwryocprVGZHye8iWaplw5ZkUYjk=; b=FlTTQC7iF03s29E8Q9ryqvX1toW56Fovs7SSGukCFnMMc5phBmXUtK03Hg+QFnJ2vq rj/n+Z8wYkCrWoBSZ4W43J4VFgTjmcAoYNkb3acqdlF8h4iObctaU46TcWJIlEJhRTBH bXixQQ8dhT41H3jRo+fviO4Y2P/2E+wQ+IqrBbTt9oWPujvQTOv5HrRmWr8v5EKSE6NX FQA2k9Non2i7sFjkwsorLvyIkx0576Ag26bUi9uaos7OzHxJ1xu+1ar8ev57EZiA5l31 Wlh0fVOLHCzavchIQWRZid493mflO8LQtAmAotFgewvtGYWT9bpsJjrBHB0FqLgwQY7c q06w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="tcc/C0wb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l5si1834711ejg.306.2021.06.10.01.03.02; Thu, 10 Jun 2021 01:03:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="tcc/C0wb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230120AbhFJIBg (ORCPT + 99 others); Thu, 10 Jun 2021 04:01:36 -0400 Received: from mail-pg1-f175.google.com ([209.85.215.175]:37829 "EHLO mail-pg1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbhFJIBf (ORCPT ); Thu, 10 Jun 2021 04:01:35 -0400 Received: by mail-pg1-f175.google.com with SMTP id t9so21942390pgn.4 for ; Thu, 10 Jun 2021 00:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z8Q0hqWJSG4oD1OkwryocprVGZHye8iWaplw5ZkUYjk=; b=tcc/C0wbgpnfYomjqB3ocj6Nb8I8xhnoeQshcEO4ywGIcuxtdcl1MlWkUXy3/cppz9 MZeqe+cn2yn0t+lFTHTGY4yLSk3q/s2itTQTRvXycbeYi1EBU+gnzh05nxs7uJTnCqpp ssh6Oe1+M3CF4xUREFWqQgEbsTBLkoGEWzYBIe73u3ZRP6uXeY4+/hzE2dIrzPu09ijI tespyZShSOfEaIMFdCb4RY5LAyugA+cTVn35V7+ipeI+sXz2ZSDk+hjsH964P7U/SO73 udNSAqgllOXdsOIduXzvflaiejZFb03Q/NcLDp4Y1YJocM9Zo2YQicT/pZ1HtnrUuuF+ PI4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z8Q0hqWJSG4oD1OkwryocprVGZHye8iWaplw5ZkUYjk=; b=NaOzZM1zDS48ytnFQDb6iD4+umwq9xj7Ai/01TkwqY0+ERGg+79WpqHmNiLST4FzTO WzXNn9kdo8oM7YGQ0S4DkFsl8b/DeCQ9yChkq8O7FRRsZ/NeLejhp0mGN8oz0zCO7dr8 0gnTcgTfC0BI8IjaWTxp0qsYVyo7wfEJc/N9IPkUpC8qtT7xa+DUYsbPqtgfCbSPdqWw hRNvyxBsnH85YH1YeD8rL5OCZhCj6DVrGJo9IUfGBfoapdv7P+FuqFYMYblzDp2Dycy+ m41FRE01+Jnlr9SOVbBqbfhkTdSP1RebKRjTRosaqPJEEbbfM8exynLrvrC9DOUKsoXj Nftw== X-Gm-Message-State: AOAM531ISb3f9Y+gLQWvSo9kVIUsGNNpuBepem74nOV9iSzCHpfvaYJp viW0ScZdu9Z9tV0l2rHv53DQHQ== X-Received: by 2002:a63:3ec3:: with SMTP id l186mr3710947pga.371.1623311919974; Thu, 10 Jun 2021 00:58:39 -0700 (PDT) Received: from localhost ([136.185.169.128]) by smtp.gmail.com with ESMTPSA id 141sm1755906pgf.92.2021.06.10.00.58.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 00:58:39 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Viresh Kumar , Ionela Voinescu Cc: linux-pm@vger.kernel.org, Vincent Guittot , Qian Cai , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: cppc: Mark frequency invariance broken Date: Thu, 10 Jun 2021 13:28:29 +0530 Message-Id: <28308fc0d38f252baf90e6ffb31fd2f8660be273.1623311808.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are few races in the frequency invariance support for CPPC driver, namely the driver doesn't stop the kthread_work and irq_work on policy exit during suspend/resume or CPU hotplug. A proper fix won't be possible for the 5.13-rc, as it requires a lot of changes. Instead of reverting the patch, mark this feature BROKEN for now. Fixes: 4c38f2df71c8 ("cpufreq: CPPC: Add support for frequency invariance") Reported-by: Qian Cai Signed-off-by: Viresh Kumar --- Rafael, please apply this for v5.13-rc if it looks fine to you. drivers/cpufreq/Kconfig.arm | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index a5c5f70acfc9..614c34350f41 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -22,6 +22,7 @@ config ACPI_CPPC_CPUFREQ config ACPI_CPPC_CPUFREQ_FIE bool "Frequency Invariance support for CPPC cpufreq driver" depends on ACPI_CPPC_CPUFREQ && GENERIC_ARCH_TOPOLOGY + depends on BROKEN default y help This extends frequency invariance support in the CPPC cpufreq driver, -- 2.31.1.272.g89b43f80a514