From: Arnd Bergmann <arnd@arndb.de>
To: Hoang-Nam Ngyuen <hnguyen@linux.vnet.ibm.com>
Subject: Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode
Date: Mon, 6 Nov 2006 22:35:28 +0100
User-Agent: KMail/1.9.5
Cc: rolandd@cisco.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
       openib-general@openib.org, hnguyen@de.ibm.com, raisch@de.ibm.com
References: <200611062226.44939.hnguyen@linux.vnet.ibm.com>
In-Reply-To: <200611062226.44939.hnguyen@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200611062235.28667.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 728
Lines: 18

On Monday 06 November 2006 22:26, Hoang-Nam Ngyuen wrote:
> -???????rblock = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
> +???????rblock = (struct hipz_query_hca*)ehca_alloc_fw_ctrlblock();

> ?
> -???????rblock = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
> +???????rblock = (struct hipz_query_port*)ehca_alloc_fw_ctrlblock();

The point Heiko made in his comment is that with ehca_alloc_fw_ctrlblock
returning a void*, you can (and _should_) remove the casts to other
pointer types.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/