Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] arm64: dts: mt8183: Add kukui-jacuzzi-cerise board
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>
References: <20210604052312.1040707-1-hsinyi@chromium.org>
From:   Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <5524c45b-0517-f2ff-b6dc-b2129fbd5d05@gmail.com>
Date:   Thu, 10 Jun 2021 11:11:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <20210604052312.1040707-1-hsinyi@chromium.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 04/06/2021 07:23, Hsin-Yi Wang wrote:
> Cerise is known as ASUS Chromebook CZ1.
> Stern is known as ASUS Chromebook Flip CZ1.
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> The difference of rev3 and non rev3 are the audio driver they use, which
> is not added in this series.
> ---
>  arch/arm64/boot/dts/mediatek/Makefile         |  4 +++
>  .../mt8183-kukui-jacuzzi-cerise-rev3.dts      | 24 +++++++++++++
>  .../mediatek/mt8183-kukui-jacuzzi-cerise.dts  | 24 +++++++++++++
>  .../mediatek/mt8183-kukui-jacuzzi-cerise.dtsi | 13 +++++++
>  .../mt8183-kukui-jacuzzi-stern-rev3.dts       | 34 +++++++++++++++++++
>  .../mediatek/mt8183-kukui-jacuzzi-stern.dts   | 34 +++++++++++++++++++
>  6 files changed, 133 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise-rev3.dts
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dts

Both files are identical. Can we merge them and use a fallback compatible, or do
you expect changes to the different revisions in the near future?

>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cerise.dtsi
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-stern-rev3.dts
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-stern.dts
> 

Same question here :)

Regards,
Matthias