Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Jun 2021 11:51:38 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     "Jin, Yao" <yao.jin@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2] perf stat: Disable NMI watchdog message on hybrid
Message-ID: <YMHgqnj2sihdbZHb@krava>
References: <20210609050600.7308-1-yao.jin@linux.intel.com>
 <YMEj6vuPcEnCz6tr@krava>
 <8faa16cf-561e-cd31-7fb2-bfad3ae27782@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8faa16cf-561e-cd31-7fb2-bfad3ae27782@linux.intel.com>
Precedence: bulk

On Thu, Jun 10, 2021 at 09:04:57AM +0800, Jin, Yao wrote:
> Hi Jiri,
> 
> On 6/10/2021 4:26 AM, Jiri Olsa wrote:
> > > +static bool is_mixed_hybrid_group(struct evsel *counter)
> > > +{
> > > +	struct evlist *evlist = counter->evlist;
> > > +	struct evsel *pos;
> > > +
> > > +	evlist__for_each_entry(evlist, pos) {
> > > +		if (perf_pmu__is_hybrid(pos->pmu_name))
> > > +			return true;
> > > +	}
> > so we care if there's at least one hybrid event in the list right?
> > it can be all full with just hybrid events, but the function name
> > suggests it's mixed with normal events
> > 
> > jirka
> > 
> 
> Yes, that's right. We only care there is at least one hybrid event in the evlist.
> 
> So do we change the function name to evlist__has_hybrid_event?

sounds good, thanks
jirka

> 
> Thanks
> Jin Yao
>