Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 0/2] Add support for ECDSA-signed kernel modules
To:     Jarkko Sakkinen <jarkko@kernel.org>
Cc:     jeyu@kernel.org, keyrings@vger.kernel.org, dhowells@redhat.com,
        dwmw2@infradead.org, zohar@linux.ibm.com, nayna@linux.ibm.com,
        linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210602143537.545132-1-stefanb@linux.ibm.com>
 <20210603064738.pwfq3n7erzmncdmw@kernel.org>
 <8b79651b-1fe4-48c0-3498-529344ac6243@linux.ibm.com>
 <20210609124412.engcrbo3fezuzyoq@kernel.org>
 <f22e7ae1-8779-e995-091c-8a899fd7fd76@linux.ibm.com>
 <20210610090323.f7b47xqxbkwnm5cx@kernel.org>
From:   Stefan Berger <stefanb@linux.ibm.com>
Message-ID: <66d4a4be-c01c-7f33-9a7f-20cfdb5dcf96@linux.ibm.com>
Date:   Thu, 10 Jun 2021 07:50:01 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210610090323.f7b47xqxbkwnm5cx@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 6/10/21 5:03 AM, Jarkko Sakkinen wrote:
> On Wed, Jun 09, 2021 at 09:58:29AM -0400, Stefan Berger wrote:
>> On 6/9/21 8:44 AM, Jarkko Sakkinen wrote:
>>> On Thu, Jun 03, 2021 at 08:32:59AM -0400, Stefan Berger wrote:
>>>> On 6/3/21 2:47 AM, Jarkko Sakkinen wrote:
>>>>>> -- 
>>>>>> 2.29.2
>>>>>>
>>>>>>
>>>>> Please instead send a fix.
>>>> We have a Fixes tag in 1/2, so we want this to propagate to older kernels
>>>> and need the fix in 1/2 for that reason.
>>>>
>>>>      Stefan
>>> So please do an additional fix and send it.
>> 1/2 is supposed to propagate to older kernels and needs to change as posted
>> here in v5 (assuming that this does indeed fix what the build bot was
>> complaining about). 2/2 also changes. A fix on top of v4 would fix 2/2 but
>> won't apply cleanly to 1/2 as cannot easily propagate to older kernels. Is
>> that what we want? Why can you not remove v4 from your queue and replace it
>> with v5?
>>
>>     Stefan
> What you can do is to send fix or fixes with appropriate fixes tags and
> I can then squash them for appropriate patches. That's less work for me.


Once you squash a fix on top of existing 1/2 , existing 2/2 will not 
apply anymore. I am not sure what to send you. I think it would take 
less time to remove the existing 2 patches and replace them with v5.

    Stefan