Content-class: urn:content-classes:message
MIME-Version: 1.0
Subject: RE: [Patch] PCI: check szhi when sz is 0 for 64 bit pref mem
Date: Mon, 6 Nov 2006 14:15:23 -0800
Message-ID: <5986589C150B2F49A46483AC44C7BCA490719C@ssvlexmb2.amd.com>
Thread-Topic: [Patch] PCI: check szhi when sz is 0 for 64 bit pref mem
Thread-Index: AccB76iQA5hCbNAARyOEuq8sJzO/XgAAAx3g
From: "Lu, Yinghai" <yinghai.lu@amd.com>
To: "Andrew Morton" <akpm@osdl.org>
cc: "Greg KH" <gregkh@suse.de>, "Andi Kleen" <ak@suse.de>,
       "linux-kernel" <linux-kernel@vger.kernel.org>
Content-Type: text/plain;
 charset=us-ascii
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 815
Lines: 29

-----Original Message-----
From: Andrew Morton [mailto:akpm@osdl.org] 
>I don't really understand what this patch does.
>We have a PCI device with a 64-bit BAR and the size is also 64-bit and
is
>larger than 4G, yes?

Yes

>But the code appears to already be attempting to handle such devices. 
>Confused.

The old code will 
Try to calculate the sz from lo 32 bit addr reg, and sz is 0 if the 64
bit resource size if 4G above, so it will continue can skip that
register, and it will go on try to treat the hi 32bit addr reg as
another 32 bit resource addr reg.

YH


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/