Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Jun 2021 13:37:33 +0100
Message-ID: <87im2lrj3m.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     John Garry <john.garry@huawei.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [report] use-after-free in __irq_resolve_mapping()
In-Reply-To: <6715098c-6845-c4a1-31ca-42101350c80a@huawei.com>
References: <6715098c-6845-c4a1-31ca-42101350c80a@huawei.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 09 Jun 2021 12:59:26 +0100,
John Garry <john.garry@huawei.com> wrote:
> 
> JFYI, on -next 20210608, I find this on my arm64 D06 and D05:

[...]

Funny what happens when you blindly replace radix_tree_delete() with
radix_tree_insert(NULL) and fail to realise that no, they aren't
equivalent... I'll pick a brown paper bag from the stack.

I'll run some more tests on some of the bigger iron before rebuilding
irq/irqchip-next, but it certainly looks less broken now.

Thanks again,

	M.

-- 
Without deviation from the norm, progress is not possible.