Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Jun 2021 14:52:09 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Icenowy Zheng <icenowy@aosc.io>
Cc:     Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Heinrich Schuchardt <xypron.glpk@gmx.de>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: a64-sopine-baseboard: change
 RGMII mode to TXID
Message-ID: <20210610125209.glrd2qlpwqiha24h@gilmour>
References: <20210609083843.463750-1-icenowy@aosc.io>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="io7uwxozpxpfiet4"
Content-Disposition: inline
In-Reply-To: <20210609083843.463750-1-icenowy@aosc.io>
Precedence: bulk


--io7uwxozpxpfiet4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 09, 2021 at 04:38:43PM +0800, Icenowy Zheng wrote:
> Although the schematics of Pine A64-LTS and SoPine Baseboard shows both
> the RX and TX internal delay are enabled, they're using the same broken
> RTL8211E chip batch with Pine A64+, so they should use TXID instead, not
> ID.
>=20
> In addition, by checking the real components soldered on both a SoPine
> Baseboard and a Pine A64-LTS, RX delay is not enabled (GR69 soldered and
> GR70 NC) despite the schematics says it's enabled. It's a common
> situation for Pine64 boards that the NC information on schematics is not
> the same with the board.
>=20
> So the RGMII delay mode should be TXID on these boards.
>=20
> Fixes: c2b111e59a7b ("arm64: dts: allwinner: A64 Sopine: phy-mode rgmii-i=
d")
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>

Applied, thanks
Maxime

--io7uwxozpxpfiet4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYMIK+QAKCRDj7w1vZxhR
xdspAP9uCPofAxHimp/PmBqZWpgDIoj9Jm6i11JcI3I8w29RPQEAl/hyxPgO52Bq
BJlk9Q56TTqTCDsAPS0wOl8F0unSGAg=
=DvGq
-----END PGP SIGNATURE-----

--io7uwxozpxpfiet4--