Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753884AbWKGA1v (ORCPT ); Mon, 6 Nov 2006 19:27:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753889AbWKGA1v (ORCPT ); Mon, 6 Nov 2006 19:27:51 -0500 Received: from mail.kroah.org ([69.55.234.183]:34268 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S1753884AbWKGA1u (ORCPT ); Mon, 6 Nov 2006 19:27:50 -0500 Date: Tue, 7 Nov 2006 09:27:34 +0900 From: Greg KH To: Mariusz Kozlowski Cc: Wolfgang M?es , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.19-rc4] usb auerswald possible memleak fix Message-ID: <20061107002734.GA5236@suse.de> References: <200611061903.09320.m.kozlowski@tuxland.pl> <200611070031.52051.m.kozlowski@tuxland.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200611070031.52051.m.kozlowski@tuxland.pl> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 931 Lines: 24 On Tue, Nov 07, 2006 at 12:31:51AM +0100, Mariusz Kozlowski wrote: > Witam, > > > Hello, > > > > There is possible memleak in auerbuf_setup(). Fix is to replace kfree() with auerbuf_free(). > > An argument to usb_free_urb() does not need a check as usb_free_urb() already does that. Not sure if I should > > send this in two separate patches. The patch is against 2.6.19-rc4 (not -mm). > > As I posted the bigger usb_free_urb() patch in another mail this one > should do only one thing which is to fix possible memory leak in > auerbuf_setup(). That is a big patch, care to split it up into smaller pieces like this one so that it is easier to review and apply? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/